镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Give the encoding and compression stream benches a longer CI timeout - #8407

Merged
jasnell merged 2 commits into
mainfrom
littledivy/2026-11-12-streams-bench-size
Nov 12, 2026
Merged

jasnell merged 2 commits into
mainfrom
littledivy/2026-11-12-streams-bench-size

Conversation

@littledivy

@littledivy littledivy commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Marks encoding-cpp, compression-cpp and compression-ts as size = "large", like the other streams benches; their smoke runs time out at 15s in the internal debug build.

Their @smoke runs time out at the default 15s in the internal debug
build. Marks them large like the other streams benches.
@littledivy
littledivy requested review from a team as code owners November 12, 2026 17:52

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 821d97aa.

This review, of fc788c80

✅ Approved — Small build-config change that gives three streams benches a longer CI timeout, with no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The change adds size = "large" to three bench targets, consistent with the other streams benches.


Reviewed commit: fc788c80

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — Small build-config change that gives three streams benches a longer CI timeout, with no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The change adds size = "large" to three bench targets, consistent with the other streams benches.


Reviewed commit: 821d97aa — same changes as fc788c80, so this is that commit's review (no new review was run; line numbers are as of fc788c80)

@jasnell
jasnell merged commit 0a89bbd into main Nov 12, 2026
23 checks passed
@jasnell
jasnell deleted the littledivy/2026-11-12-streams-bench-size branch November 12, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants