Repository navigation
Give the encoding and compression stream benches a longer CI timeout - #8407
Conversation
Their @smoke runs time out at the default 15s in the internal debug build. Marks them large like the other streams benches.
There was a problem hiding this comment.
Superseded by the review of
821d97aa.
This review, of fc788c80
✅ Approved — Small build-config change that gives three streams benches a longer CI timeout, with no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The change adds size = "large" to three bench targets, consistent with the other streams benches.
Reviewed commit: fc788c80
There was a problem hiding this comment.
✅ Approved — Small build-config change that gives three streams benches a longer CI timeout, with no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The change adds size = "large" to three bench targets, consistent with the other streams benches.
Reviewed commit: 821d97aa — same changes as fc788c80, so this is that commit's review (no new review was run; line numbers are as of fc788c80)
Marks
encoding-cpp,compression-cppandcompression-tsassize = "large", like the other streams benches; their smoke runs time out at 15s in the internal debug build.