Repository navigation
Conversation
Both suites can exceed the 15-second medium-test timeout in downstream debug builds while still progressing through their cases. Rerunning the build still timed out both Wasm WPT variants and the all-compat encoding smoke test. Use the large test size for a 60-second downstream budget, matching the TypeScript encoding benchmark. Keep all cases and assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wasm JavaScript API WPT suite and C++ encoding benchmark smoke tests should exercise every case in downstream debug builds. Both inherit the medium test size, which edgeworker maps to a 15-second timeout. The downstream debug build killed both Wasm WPT variants and the all-compat encoding benchmark at that deadline while they were still progressing through their cases.
Classify both suites as large, giving downstream debug builds 60 seconds, as already used by the TypeScript encoding benchmark. Every WPT subtest and benchmark case remains enabled, and a hung suite still fails at the standard large-test deadline.