Repository navigation
node:buffer: ignore encoding in Buffer.alloc when fill is not a string - #8402
Open
umeraamir69 wants to merge 1 commit into
Open
umeraamir69 wants to merge 1 commit into
umeraamir69 wants to merge 1 commit into
Conversation
Match Node.js: encoding only applies if fill is a string. Passing encoding with a number/Buffer fill previously threw ERR_INVALID_ARG_TYPE. Closes cloudflare#8286
|
All contributors have signed the CLA ✍️ ✅ |
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buffer.alloc(size, fill, encoding)now matches Node.js:encodingis only used/validated whenfillis a string.ERR_INVALID_ARG_TYPE.buffer-nodejs-test.jsfor the cases from node:buffer: Buffer.alloc(size, fill, encoding) throws when fill is a number or a Buffer #8286.Closes #8286
Test plan
bazel test //src/workerd/api/node/tests:buffer-nodejs-test050505,000000,070707,616261Note: Bazel was not available in this environment, so the buffer test target was not run locally.