镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

node:buffer: ignore encoding in Buffer.alloc when fill is not a string - #8402

Open
umeraamir69 wants to merge 1 commit into
cloudflare:mainfrom
umeraamir69:fix/buffer-alloc-encoding-8286
Open

umeraamir69 wants to merge 1 commit into
cloudflare:mainfrom
umeraamir69:fix/buffer-alloc-encoding-8286

Conversation

@umeraamir69

Copy link
Copy Markdown

Summary

Closes #8286

Test plan

Note: Bazel was not available in this environment, so the buffer test target was not run locally.

Match Node.js: encoding only applies if fill is a string. Passing encoding
with a number/Buffer fill previously threw ERR_INVALID_ARG_TYPE.

Closes cloudflare#8286
@umeraamir69
umeraamir69 requested review from a team as code owners November 12, 2026 16:50
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

@umeraamir69

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:buffer: Buffer.alloc(size, fill, encoding) throws when fill is a number or a Buffer

1 participant