Repository navigation
fix: node:buffer: Buffer.alloc(size, fill, encoding) throws when fill is a nu... - #8364
Open
Roshan931 wants to merge 1 commit into
Conversation
Signed-off-by: Robert Markovski <5818108+Roshan931@users.noreply.github.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
Author
|
I have read the CLA Document and I hereby sign the CLA |
jasnell
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8286
Root cause
Buffer.alloc passes encoding in fill()'s start slot
Changes
This issue was fixed with Prilog. This is our way of giving back to the open source community.