Repository navigation
Get rid of care of Google/Apple contact code #316
Description
Code that reaches to Google/Apple services for contact data is defunct. Remove it.
Note that the code extract contact information from attached contact files (.vcf, .vcard) in emails is working correctly and we don't want to remove it.
Metadata
Metadata
Assignees
Labels
No labels
Activity
wojcikstefan commentedon Feb 18, 2022
Why is that code defunct btw? Is it no longer allowed for integrations to fetch Google/Apple contacts via their APIs?
marcospri commentedon Sep 18, 2026
I arrived here via looking at this missing names:
https://github.com/closeio/sync-engine/blob/master/inbox/contacts/google.py#L184
This is very confusing, it looks like it should fail to load that module but maybe this is not used at all? I'd vote to remove it but ideally understanding what replaces its.
squeaky-pl commentedon Oct 20, 2026
Because we don't enable the threads that import contacts in our setup. I believe the APIs still work but Python libraries sync-engine uses are unmaintained and don't even work on Python 3
I don't believe we even import this module at runtime because we run sync engine without contacts import enabled. I agree this is suprising and the whole thing should have been nuked long time ago.
wojcikstefan commentedon Oct 20, 2026
@squeaky-pl should be easy to get rid of it then, right? Wanna give it a shot?