Repository navigation
Implement service dependencies for Docker-Compose V3 - #187
Merged
Merged
Conversation
This was referenced Apr 13, 2020
Hanefi Onaldi (hanefi)
force-pushed
the
bump-docker-compose-3
branch
from
April 13, 2020 14:49
c6aa72b to
0b3dbea
Compare
Onur Tirtir (onurctirtir)
approved these changes
Apr 24, 2020
| done | ||
|
|
||
| >&2 echo "Manager is up - starting worker" | ||
|
|
Member
There was a problem hiding this comment.
giving a link (to docker-entrypoint.sh) and explaining below line, we can merge the pr (line 13)
Hanefi Onaldi (hanefi)
force-pushed
the
bump-docker-compose-3
branch
from
April 30, 2020 09:53
0b3dbea to
ec74734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker Version 3 has some changes in service dependency definitions. We designed Citus
docker-compose.ymlin a way that the services should be run in the order below:Docker Compose Version 3 no longer supports
depends_onstatements.Docker startup order docs also state that:
This means that the worker services should be able to understand if the
membership-manageris ready, and this will be done via the existence of the file/healthcheck/manager-readythat will reside in a volume/healthcheckthat is also attached to the worker nodes as well as the Membership Manager.Blocked on: citusdata/membership-manager#9