Repository navigation
[cel-types] Add TypeDefSet and bidirectional FileDescriptorSet conversion. - #2342
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…sion. Provide `cel::TypeDefSet` to represent an indexed collection of unique `TypeDef` objects and enums with Protobuf and YAML serialization helpers (`TypeDefSetToProto`, `TypeDefSetFromProto`, `TypeDefSetToYaml`, `TypeDefSetFromYaml`). Extend `ProtoObjectProperties`, `ProtoFieldProperties`, and `ProtoEnumProperties` with file names, extension ranges, real oneof names, explicit field labels, non-default field types, and enum default values so protobuf schemas can round-trip without losing fidelity. Implement `FileDescriptorSetToTypeDefSet` and `TypeDefSetToFileDescriptorSet` in `common/typedef/proto_to_typedef` to convert between `FileDescriptorSet` and `TypeDefSet`, mapping CEL well-known types to built-in `TypeSpec` representations and reconstructing nested message/enum hierarchies, real and synthetic `proto3_optional` oneofs, map entries, and leading source comments. PiperOrigin-RevId: 996098089
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cel-types] Add TypeDefSet and bidirectional FileDescriptorSet conversion.
Provide
cel::TypeDefSetto represent an indexed collection of uniqueTypeDefobjects and enums with Protobuf and YAML serialization helpers (TypeDefSetToProto,TypeDefSetFromProto,TypeDefSetToYaml,TypeDefSetFromYaml).Extend
ProtoObjectProperties,ProtoFieldProperties, andProtoEnumPropertieswith file names, extension ranges, real oneof names, explicit field labels, non-default field types, and enum default values so protobuf schemas can round-trip without losing fidelity. ImplementFileDescriptorSetToTypeDefSetandTypeDefSetToFileDescriptorSetincommon/typedef/proto_to_typedefto convert betweenFileDescriptorSetandTypeDefSet, mapping CEL well-known types to built-inTypeSpecrepresentations and reconstructing nested message/enum hierarchies, real and syntheticproto3_optionaloneofs, map entries, and leading source comments.