Repository navigation
Conversation
b1c771f to
3a142af
Compare
mrenvoize
left a comment
There was a problem hiding this comment.
Approving. The hook filters in both DoSettings and SaveSettings in userprefs.cgi. Minor: the Example extension's hook skips example_pref, which is a custom form field rather than a General Settings entry, so the example is a no-op; worth changing it to a real setting name. The upstream twin (bugzilla/bugzilla#255) has a slightly different DoSettings structure, so please keep behaviour in step.
Extension can add setting names to the `%skip_settings` hash to exclude them from the General Settings tab in User Preferences (for example if it will be managing them with custom UI from an additional settings tab).
ae45860 to
1281a61
Compare
mrenvoize
left a comment
There was a problem hiding this comment.
Re-approving after the rebase. The Example extension now registers a real setting (product_chooser), skips it in General Settings via the new hook, and saves it from its own tab with validation, which resolves my earlier comment about example_pref. The hook is filtered in both display and save paths in userprefs.cgi.
Details
Extension can add setting names to the
%skip_settingshash to exclude them from the General Settings tab in User Preferences (for example if it will be managing them with custom UI from an additional settings tab).Additional info
Test Plan
#156 will make use of this once it lands