Repository navigation
Conversation
justdave
requested changes
Jul 13, 2026
|
|
||
| package Bugzilla::Extension::MoreBugUrl::BitBucket; | ||
|
|
||
| use 5.10.1; |
Member
There was a problem hiding this comment.
This is going to fail tests as soon as we merge main back into this... This applies to every new file. Needs to be use 5.14.0; now and you'll need to merge from main at the same time you fix this to avoid test failures.
Member
|
The BMO/harmony gap report pointed out BMO had consolidated all of this in a single place... does that affect how we do this? Would it be better to take the BMO one rather than the prior upstream one? |
Contributor
Author
|
I actually think this is the cleaner final path personally.. but I'm open to opinions. |
Restores the bug_url_sub_classes hook (previously dropped in Harmony) and ports the MoreBugUrl extension from upstream, adding recognition of additional external bug trackers in the See Also field: BitBucket, ReviewBoard, RT, PHP, Redmine, Savane and WineHQ Forums. Bugzilla::BugUrl::class_for now fires the bug_url_sub_classes hook so extensions can append their own Bugzilla::BugUrl sub-classes. Core trackers are still tried first; extension-provided trackers are appended last. Bugzilla/Hook.pm documents the hook, matching upstream. The upstream extension's Rietveld and GetSatisfaction trackers are omitted as both services are defunct. The extension modules are adapted to Harmony conventions (use 5.14.0) and the extension ships enabled (no "disabled" marker).
The extension ships a user-error-bug_url_invalid_tracker hook template, but the core user-error.html.tmpl never processed that hook, so users entering an unsupported See Also URL were never shown the extra trackers. Add the Hook.process() call (as in upstream 5.2) inside the tracker list. Add extensions/MoreBugUrl/t/matchers.t covering each tracker matcher (accepted and rejected URLs), registration through bug_url_sub_classes, class_for() resolution and the rendered error page. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the bug_url_sub_classes hook (previously dropped in Harmony) and ports the MoreBugUrl extension from upstream, adding recognition of additional external bug trackers in the See Also field: BitBucket, ReviewBoard, RT, PHP, Redmine, Savane and WineHQ Forums.
Bugzilla::BugUrl::class_for now fires the bug_url_sub_classes hook so extensions can append their own Bugzilla::BugUrl sub-classes. Core trackers are still tried first; extension-provided trackers are appended last. Bugzilla/Hook.pm documents the hook, matching upstream.
The upstream extension's Rietveld and GetSatisfaction trackers are omitted as both services are defunct. The extension modules are adapted to Harmony conventions (use 5.10.1) and the extension ships enabled (no "disabled" marker).