镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Handle P2 Repo features in bundle graph drag & drop - #7162

Merged
chrisrueger merged 1 commit into
bndtools:masterfrom
chrisrueger:add-p2-feature-dragdrop-support-for-bundlegraph
Mar 17, 2026
Merged

chrisrueger merged 1 commit into
bndtools:masterfrom
chrisrueger:add-p2-feature-dragdrop-support-for-bundlegraph

Conversation

@chrisrueger

@chrisrueger chrisrueger commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

First draft for recent #7124 (Support for Eclipse Features in p2 repositories)

Add support for dropping P2 features and feature-related nodes into the bundle graph. The drop adapter now recognizes RepositoryFeature, FeatureVersionNode, FeatureFolderNode, IncludedFeatureItem and IncludedBundleItem (for P2Repository), extracts plugin ids and versions, and populates repoBundles/repoVersions accordingly. New helper methods (addFeature, addFeatureFolderNode, addIncludedFeatureItem, getFeatureChildren) centralize processing of features, included bundles/features and plugin versions. Errors while resolving features from P2Repository are caught and logged.

You can now drop:

  • a whole P2Repo (worked already)
  • a P2Feature
  • an Included Features folder
    • an Included Feature Item
  • an Included Bundles folder
    • an Included Bundle Item
image image

@chrisrueger chrisrueger changed the title Handle P2 features in bundle graph drop Handle P2 features in bundle graph drag & drop Mar 16, 2026
@chrisrueger chrisrueger changed the title Handle P2 features in bundle graph drag & drop Handle P2 Repo features in bundle graph drag & drop Mar 16, 2026
@peterkir

Copy link
Copy Markdown
Contributor

Looks great! Merge it 👍

Add support for dropping P2 features and feature-related nodes into the bundle graph. The drop adapter now recognizes RepositoryFeature, FeatureVersionNode, FeatureFolderNode, IncludedFeatureItem and IncludedBundleItem (for P2Repository), extracts plugin ids and versions, and populates repoBundles/repoVersions accordingly. New helper methods (addFeature, addFeatureFolderNode, addIncludedFeatureItem, getFeatureChildren) centralize processing of features, included bundles/features and plugin versions. Errors while resolving features from P2Repository are caught and logged.

Support recursive P2 feature includes

Replace direct addFeature calls with addFeatureRecursive to collect bundles from a feature and all transitively included sub-features.

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@chrisrueger
chrisrueger force-pushed the add-p2-feature-dragdrop-support-for-bundlegraph branch from 2b0a9a3 to a2e3912 Compare March 17, 2026 12:51
@chrisrueger
chrisrueger merged commit ca8af43 into bndtools:master Mar 17, 2026
7 checks passed
@chrisrueger

Copy link
Copy Markdown
Contributor Author

Looks great! Merge it 👍

Squashed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants