镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Restore RepositoryResourceElement label/icon logic and ContinueSearchElement/LoadingContentElement handlers - #7148

Merged
peterkir merged 2 commits into
ecl-fea-supportfrom
copilot/sub-pr-7124-again
Mar 15, 2026
Merged

peterkir merged 2 commits into
ecl-fea-supportfrom
copilot/sub-pr-7124-again

Conversation

Copilot AI commented Mar 15, 2026 •

Copy link
Copy Markdown
Contributor

PR #7124 accidentally gutted the RepositoryResourceElement branch in RepositoryTreeLabelProvider.update(), leaving it empty — causing search results to render blank with no icon. It also dropped the ContinueSearchElement and LoadingContentElement branches entirely.

Changes

  • RepositoryResourceElement: Restored identity + version label and matchImg icon
  • ContinueSearchElement: Re-added "Continue Search on repository..." label with HyperlinkStyler
  • LoadingContentElement: Re-added element.toString() label with loadingImg icon
  • Import: Re-added HyperlinkStyler import that was removed alongside the above

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…lement, and LoadingContentElement

Co-authored-by: peterkir <250545+peterkir@users.noreply.github.com>

Copilot AI commented Mar 15, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bndtools.jfrog.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xms1024m -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xms1024m -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback by restoring previous logic for Eclipse Features support Restore RepositoryResourceElement label/icon logic and ContinueSearchElement/LoadingContentElement handlers Mar 15, 2026
Copilot AI requested a review from peterkir March 15, 2026 15:35
@peterkir
peterkir marked this pull request as ready for review March 15, 2026 15:42
@peterkir
peterkir merged commit e7c9f4c into ecl-fea-support Mar 15, 2026
20 checks passed
@peterkir
peterkir deleted the copilot/sub-pr-7124-again branch March 15, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants