Repository navigation
tests: retry phys_rep_tiered allowed-source checks on empty rtn - #6286
Merged
markhannum merged 1 commit intoOct 8, 2026
Merged
Conversation
A transient hostname-resolution failure on the test driver made cdb2sql fail to connect; the empty rtn was misreported as "allowed self as source". Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
roborivers
approved these changes
Oct 3, 2026
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
truncatesc_offline_generated [failed with core dumped] **quarantined**
logfill [db unavailable at finish] **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
roborivers
approved these changes
Oct 4, 2026
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phys_rep_tiered failed in an rr test run with "physrep_allowed_source phys_rep_tiered_82951_repl_m2 allowed self as source". The m2 node was healthy throughout; the test driver briefly couldn't resolve the hostname m2 (getaddrinfo -2), so cdb2sql never connected and the empty rtn was treated as a failed check.
This adds an allowed_source_rtn helper that retries the query for up to 60s while no rtn comes back, and uses it for every allowed-source check in physrep_allowed_source and physrep_rtcpu_source.