Repository navigation
Conversation
The relay directory only reports channel ids for agents since block#6086, so the Channels tab read an always-empty name list. Name each id from the viewer's channel list instead. Signed-off-by: Tom Birch <tom@neara.com>
🔐 Codex Security Review
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The relay directory stopped sending channel names for agents in #6086. It sends only the IDs of channels where the agent has the
botrole. The profile panel's Channels tab still listed names. So an agent this Desktop doesn't run itself shows an empty Channels tab, even when it's in channels with you. This affects an agent run elsewhere, such as a bot with an owner tag, or your agent on another device.Channels missing from your channel list are skipped. They have no name to show, and you can't open them anyway.
Evidence
New test
deriveProfileChannels names an unmanaged agent's channels from their ids: an agent withchannels: []and threechannelIds, two of them in the viewer's channel list.[]instead ofalpha,beta).pnpm testpasses (6951 + 185), andtsc --noEmitand biome are clean.Not yet checked in the app.
Merge Danger
Door: two-way
Blast Radius: small. One profile panel tab. Agents this Desktop runs still add channels from membership, as before.