镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(desktop): list unmanaged agents' channels on the profile panel - #9318

Draft
froody wants to merge 1 commit into
block:mainfrom
froody:agent-profile-channel-ids
Draft

froody wants to merge 1 commit into
block:mainfrom
froody:agent-profile-channel-ids

Conversation

@froody

@froody froody commented Nov 10, 2026

Copy link
Copy Markdown

Summary

The relay directory stopped sending channel names for agents in #6086. It sends only the IDs of channels where the agent has the bot role. The profile panel's Channels tab still listed names. So an agent this Desktop doesn't run itself shows an empty Channels tab, even when it's in channels with you. This affects an agent run elsewhere, such as a bot with an owner tag, or your agent on another device.

 deriveProfileChannels(pubkey, relayAgent, managedAgent, channels)
-  for name in relayAgent.channels          # always [] since #6086
-    link(relayAgent.channelIds[i] ?? name, name)
+  for id in relayAgent.channelIds
+    if channels has id: link(id, channels[id].name)
   if managedAgent: add channels whose memberPubkeys include pubkey

Channels missing from your channel list are skipped. They have no name to show, and you can't open them anyway.

Evidence

New test deriveProfileChannels names an unmanaged agent's channels from their ids: an agent with channels: [] and three channelIds, two of them in the viewer's channel list.

  • Before: fails ([] instead of alpha, beta).
  • After: passes. Full pnpm test passes (6951 + 185), and tsc --noEmit and biome are clean.

Not yet checked in the app.

Merge Danger

Door: two-way

Blast Radius: small. One profile panel tab. Agents this Desktop runs still add channels from membership, as before.

The relay directory only reports channel ids for agents since block#6086, so the
Channels tab read an always-empty name list. Name each id from the viewer's
channel list instead.

Signed-off-by: Tom Birch <tom@neara.com>
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 44b3c4823f0cf1f7715f85dbf5566cb64e848162...00b0cd0e91d8d18a10517987983e31e108cc720a.
A new review must complete for this exact range. When manual authorization
is required, a user with write access must comment exactly
@buzz-security-review 00b0cd0e91d8d18a10517987983e31e108cc720a to authorize a new review.
Any previous review applies only to its recorded range.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant