Repository navigation
Conversation
A thread row shows its newest event but took its label from the highest-priority category in the group. With observed replies in Activity, a thread with an older mention and a newer plain reply showed that reply under "Mentioned in". Label the displayed event instead; the group's categories still drive the Mentions filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
klopez4212
approved these changes
Nov 9, 2026
brow
merged commit Nov 9, 2026
d35a9a0
into
kennylopez-mobile-thread-activity-20261109
42 of 44 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
kennylopez-mobile-thread-activity-20261109, the branch of #9286 Activity observed replies.Context. Tom's mobile review team reviewed #9286 and approved it with this one small fix. Report and discussion: buzz://message?channel=e71f9a2a-ac46-473d-a24e-5e16fd8cb7b1&id=fdd32a9ef3580be56547ce7b4451404525b0d4cd56e291a2ce807ab68e035875
Problem. An Activity row shows the newest event in its thread, but its label comes from the highest-priority category in the thread. When you are mentioned in a thread and someone later replies without mentioning you, the row shows that reply under the label "Mentioned in".
Fix. The label now comes from the event the row shows. Filters still use all categories in the thread, so the Mentions filter does not change.
Validation
New test in
inbox_item_test.dartfails without the fix. Full mobile suite andflutter analyzepass.Please approve and merge this into your branch. Tom's team then approves and merges #9286.
🤖 Generated with Claude Code