Repository navigation
NEXUS-4336: Wait for desktop-provider socket ownership proof - #9270
Merged
Merged
Conversation
Signed-off-by: Kyle Zemek <kylez@squareup.com> Co-authored-by: Codex <noreply@openai.com>
kazemek21
marked this pull request as ready for review
November 9, 2026 03:55
kazemek21
temporarily deployed
to
codex-review
November 9, 2026 03:56 — with 
GitHub Actions
Inactive
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
fsola-sq
added a commit
that referenced
this pull request
Nov 9, 2026
…-profile * origin/main: (307 commits) fix: inline ARM64 atomics in Sprig image build (#9291) fix(mobile): show observed thread replies in Activity (#9286) Enable mobile huddles with Codex agents (#9269) fix(mobile): read mentions taller than the screen (#9243) test(relay): give every media e2e upload its own blob hash (#9272) Add invite preview video and fallback poster (#9282) NEXUS-4336: Wait for desktop-provider socket ownership proof (#9270) fix: unblock image audit with patched MCP SDK (#9287) feat(ci): allow admin dispatch of desktop candidate validation (#9288) feat(mobile): tag the reacted-to message author on reactions (#9141) fix(mobile): steady New DM picker rows and animate picks (#9249) perf(mobile): keep remote images on disk and show small ones as thumbnails (#9158) fix(relay): deliver slow cross-node events late instead of closing their recipients (#9235) fix(mobile): read only shown events from filtered Activity rows (#9215) fix(mobile): show the channel name as the notification subtitle (#9173) fix(mobile): keep Home's header clean under sheets (#9152) fix(mobile): show already-loaded custom emoji in the iOS reactions sheet (#9150) mobile: add follow and remind actions to inbox row menu (#9142) fix(mobile): start no threads in Solo chats (#9123) mobile: persist user profiles so names and avatars render on launch (#9116) ... Signed-off-by: Franco Sola <fsola@squareup.com> # Conflicts: # docs/nips/NIP-FA.md # docs/nips/NIP-FI.md
wpfleger96
added a commit
that referenced
this pull request
Nov 9, 2026
…e-mode * origin/main: (36 commits) feat(relay): let an operator mint invites for a community owner or admin (#9265) fix: inline ARM64 atomics in Sprig image build (#9291) fix(mobile): show observed thread replies in Activity (#9286) Enable mobile huddles with Codex agents (#9269) fix(mobile): read mentions taller than the screen (#9243) test(relay): give every media e2e upload its own blob hash (#9272) Add invite preview video and fallback poster (#9282) NEXUS-4336: Wait for desktop-provider socket ownership proof (#9270) fix: unblock image audit with patched MCP SDK (#9287) feat(ci): allow admin dispatch of desktop candidate validation (#9288) feat(mobile): tag the reacted-to message author on reactions (#9141) fix(mobile): steady New DM picker rows and animate picks (#9249) perf(mobile): keep remote images on disk and show small ones as thumbnails (#9158) fix(relay): deliver slow cross-node events late instead of closing their recipients (#9235) fix(mobile): read only shown events from filtered Activity rows (#9215) fix(mobile): show the channel name as the notification subtitle (#9173) fix(mobile): keep Home's header clean under sheets (#9152) fix(mobile): show already-loaded custom emoji in the iOS reactions sheet (#9150) mobile: add follow and remind actions to inbox row menu (#9142) fix(mobile): start no threads in Solo chats (#9123) ... Signed-off-by: Will Pfleger <wpfleger@block.xyz>
This was referenced Nov 11, 2026
kleinbem
added a commit
to kleinbem/nix-packages
that referenced
this pull request
Nov 11, 2026
…kage (#296) Three canaries fail on upstream main for reasons unrelated to the nixpkgs recipes under review. Each fix stays in the canary's overlay, so the pinned release builds don't change. - **buzz-app** (#215): main dropped the `/usr/bin/printenv` git shim in `crates/plugin-manager/src/imports.rs` (block/buzz-app#2665, which supersedes block/buzz-app#2417), so the recipe's `--replace-fail` stopped matching in patchPhase. The canary turns that substitution into `--replace-quiet`. The 0.7.16 recipe keeps it as is; it can go once the recipe's buzz-app version contains #2665. - **mesh-llm** (#253): `skippy-ffi` `llama_draft::tests::mirrors_match_the_pinned_upstream_layouts` fails on every platform (176 vs 168). That isn't our llama.cpp: the size comes from the committed bindgen output (`src/bindings/llama.rs`), which gained `moe_cache_cpu_share` with the b12199 upgrade (Mesh-LLM/mesh-llm#2953) while the test kept the old numbers. Upstream CI doesn't run that crate's tests. Skipped in the canary. upstream: Mesh-LLM/mesh-llm#2987 - **Buzz** (#291): a new buzz-cli test (block/buzz#9270) checks its child with `/bin/kill`, which the Linux sandbox lacks (darwin passed). The canary substitutes util-linux's `kill` on Linux. tracking: #295 Checked by evaluating each overlay against `kleinbem/nixpkgs` buzz-app-prep, mesh-llm-dev and buzz-next. I'll start the three canaries on this branch to confirm. Part of #215, #253, #291. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Chores** * Updated packaging adjustments for Buzz, Buzz CLI and Mesh LLM. These changes affect build and test handling and do not add or change end-user features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Retry missing desktop-provider socket ownership proof on the same open connection, within the existing five-second limit. Credentials and provider requests remain withheld until the exact server-side socket belongs to the caller's UID; a wrong UID or lookup error still fails immediately.
The ownership code moves into its own module to keep the existing oversized file within the repository's file-size ratchet. The macOS lookup now bounds output and checks the child exit status while retaining cancellation cleanup.
Related issue
Fixes NEXUS-4336.
Testing
42 provider tests passed on Linux, including synthetic transport tests for delayed/absent proof, wrong UID, lookup failure, deadline expiry, zero early request bytes, and child cleanup after timeout/cancellation. Targeted Clippy, formatting, and file-size checks passed. Removing the retry or bypassing proof caused the production-path regression to fail.
Native macOS execution, installed/source parity, and the cause of any live authentication failure remain unverified. This source change does not establish installed or live recovery. No human-test attestation is claimed.
Generated with Codex. Posted by Codex (gpt-6.1-sol) on behalf of kylez.