feat(mobile): rename Activity and add header filters by brow · Pull Request #9213 · block/buzz

brow · 2026-11-06T19:44:37Z

The UI-only part of #9186 by @klopez4212, split out so it can land without the Activity sync changes.

The Inbox page becomes Activity, with header controls instead of menus: a type menu (All, Threads, Mentions, DMs, Reminders, Drafts), a sender menu (Anyone, People, Agents) and an Unread toggle. All of them filter the feed the app already loads.
Activity and Search get a top edge fade. Bulk mark-as-read and the "New" divider are gone.
DM thread replies group with their DM row, so the DMs filter includes them.

Left out, for a separate sync PR: the Activity history cache, subscriptions to every joined channel, the refresh coalescer, thread-follow evidence, Reactions and Solo rows, and the read-state changes. The Activity provider and read-state writes are unchanged from main.

One fix on top: the iOS filter labels pass an unscaled font size, since the native button already applies Dynamic Type. Before, large text was scaled twice.

Validation

Kenny's added tests for the header controls (tabs_journey) and TopEdgeFade, adjusted for the removed Reactions option. Added tests for the DM filter, marking a DM row with replies under two thread roots read, and sender filtering per event.
Full mobile suite: see the latest CI run. Locally, 11 push and notification-toggle tests fail identically on an unchanged checkout.
Automated simulator run (iPhone 17 Pro, iOS 27) of a build combining this PR with its sibling split: Home rows measure 44 pt, the bell opens Activity and shows its dot after a row is marked unread, type/sender/Unread filters each narrow the feed, a row opens its conversation, Search results scroll under the fade, and filter labels fit at the largest text size. Screenshots are in Buzz rather than here because they show internal test data. Android was covered only by widget tests.

Before merge

Automated simulator run of Activity filters, row taps, read and unread, and Search, with screenshots.

🤖 Generated with Claude Code

UI-only subset of #9186. Renames the Inbox page to Activity and replaces its menus with header controls: a type menu (All, Threads, Mentions, DMs, Reminders, Drafts), a sender menu (Anyone, People, Agents) and an Unread toggle, all filtering the existing feed on the client. Adds a top edge fade to Activity and Search and removes bulk mark-as-read. DM thread replies now group with their DM. Leaves the Activity provider, history fetches, subscriptions and read-state writes unchanged. iOS filter labels pass an unscaled font size so native Dynamic Type applies once. Co-authored-by: kenny lopez <klopez4212@gmail.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

brow · 2026-11-06T19:44:45Z

@codex review

chatgpt-codex-connector · 2026-11-06T19:45:04Z

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-06T20:35:46.050322Z	`6999bb9`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d385c5fd3c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

A DM row can group replies under several thread roots, so marking it read now advances the DM channel marker instead of one thread marker. The People and Agents filters now apply to each event before regrouping, so a row keeps the matching sender's activity when a later reply comes from the other kind of sender. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

brow · 2026-11-06T20:00:07Z

@codex review

github-actions · 2026-11-06T20:02:39Z

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

Exact PR diff: 6c3ffd160bc0caf8946ce57f3aa50e4f5c615e8e...6999bb9a8d2eea26190e2d48f9a704081e9def1f

Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.

Review Summary

Overall Risk: MEDIUM

One read-state correctness regression can silently mark filtered-out thread messages as read.

Findings

[MEDIUM] `Preserve hidden unread messages when marking filtered threads read`

Category: Reliability
Location: mobile/lib/features/activity/activity_page.dart:224 (source)
Description: For a non-DM thread containing an older unread human mention and a newer agent reply, select Agents and mark the displayed row read. The new filtering removes the human message from groupItems, but per-message read handling applies only to DM rows. The non-DM path advances the shared thread marker to the agent reply's timestamp, so inboxEventReadAt also considers the hidden human mention read.
Impact: Unseen mentions lose their unread status and disappear from unread-only views. The thread marker is persisted and synchronized to other clients.
Recommendation: Use per-message read markers for partial non-DM rows as well. Add coverage showing that reading an Agents-filtered thread leaves an older hidden human mention unread.

Notes

Review used read-only static inspection. Builds and tests were not executed, as requested.

_{Generated by Codex Security Review |

Requested by: @brow |

Workflow run}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 724f8d1702

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The DM timeline hides thread replies, so opening a DM reply from Activity without its thread root showed top-level history instead of the reply. Restore main's navigation, which opens the reply's thread, and cover the DM case alongside the channel case. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

The Activity type menu's accessibility label replaced the visible selection, so VoiceOver read only "Activity type". Include the selected option, matching the sender menu. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

brow · 2026-11-06T20:12:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a15ed77a41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The Agents/People filter now counts channel bot members as agents, as the rows already do. The Threads filter keeps only thread replies before grouping, so a DM row shows and opens its reply instead of a later top-level message. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

brow · 2026-11-06T20:21:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13d28cc755

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Hidden DMs group as DMs, so the DMs filter still shows them while resurfacing is pending. - Marking a filtered DM row read (Threads, Mentions or a sender filter) marks only the events it shows instead of the whole DM. - A sender filter preloads every author's profile, so agents known only by profile ownership aren't stuck classified as people. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>

brow · 2026-11-06T20:30:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6999bb9a8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Summary Follow-up to [#9213 Activity filters UI](#9213), from its [last Codex finding](#9213 (comment)). With Threads, Mentions or a People/Agents filter active, an Activity row holds only part of its conversation. Marking it read advanced the `thread:<root>` (or channel) marker through the row's latest event, which also read replies the filter hid. For example, reading a person's reply in People also read an older agent reply in the same thread. Filtered rows now advance the synced thread or channel marker through every event that is read, stopping just before the first unread event the filter hides, and write local `msg:` marks only for shown events past that point. Once the hidden event is read too, the marker catches up and syncs both. This also fixes filtered DM rows from #9213, whose `msg:`-only reads never synced to other devices. Unfiltered rows are unchanged. ## Testing - New widget test: "reading a thread row under People leaves hidden agent replies unread". It fails without the fix, and checks the synced marker stops short of a hidden unread reply, then advances fully once nothing hidden is unread. - `flutter test test/features/activity/` (136 pass) and `flutter analyze` on the activity feature. ## Before merge - [x] Automated simulator run (iPhone 17 Pro sim, iOS 27, re-run on d17f79a; the catch-up change in 28b927e is covered by the widget test): with Agents selected, marked a channel mention row unread then read; it stays read under Anyone and after relaunch. Screenshots are in Buzz (internal data). The test account has no thread mixing agent and human replies, so the hidden-reply case is covered by the widget test. - [x] Main vs PR simulator comparison of a filtered thread read with a hidden unread reply (iPhone 17 Pro sim, iOS 27; main at [65e8643](65e864301d), PR at [b2414cf](b2414cf)). Neither test account has a real thread with both a person and an agent mention, so this runs the Activity page on the simulator with seeded events through the widget-test harness (`flutter run` of the test). The thread has an older agent mention and a newer person mention, both unread. The steps: choose People, swipe the person row to read it, switch to Agents, then Anyone. Left is main, right is this PR. - After the read, the person row is read under People on both. - Under Agents, main shows the older agent reply as read (the thread marker moved to the person reply's timestamp). The PR keeps it unread (marker stops one second before the agent reply). ![cmp-4-agents-after](https://github.com/raw/block/buzz/aa95e2b22a6ac7815ba1ba36453c0c6c3a994bec/pr-9215--cmp-4-agents-after.png) - Under Anyone, the thread row is read on main and still unread on the PR, because its agent reply is unread. ![cmp-5-anyone-after](https://github.com/raw/block/buzz/aa95e2b22a6ac7815ba1ba36453c0c6c3a994bec/pr-9215--cmp-5-anyone-after.png) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

## Summary A reply in a thread you started, participated in, or followed can light a mobile channel's attention dot without appearing in Activity. Activity now includes eligible replies already observed by the channel unread pipeline in **All** and **Threads**. Tapping a row uses the existing oldest-unread reply and thread navigation. Retain the reply payload alongside its bounded unread evidence, then merge by event ID with the addressed feed. Mentions retain their category and do not duplicate. Deletion, eviction, and account/community resets share the same registry. This adds no relay queries or subscriptions. Coverage follows the existing channel unread catch-up and live subscriptions. This does not introduce complete historical thread discovery: replies outside that retained window, and replies not eligible for the channel attention dot, are not newly fetched. ### Related issue Related to #9271 (clearing channel rows) and closed #9186 (broader Activity feed expansion). #9213 supplied the existing Activity filters. This PR connects existing observed replies to those filters. ### Testing - Full mobile suite, push-unconfigured tests, analysis, formatting and file-size checks. - Production-provider regression: cold catch-up, live reply, mention deduplication, excluded unrelated/quiet replies, thread read markers, deletion/replay and identity reset. - Real Activity widget journey with fake relay/storage boundaries: show the unmentioned reply, select Threads, tap the row, and verify the reply ID and thread ID passed to the conversation page. - Mutation check: removing reply-payload retention makes the widget journey fail because the reply is absent. - Independent agent source review: no blockers. ### Preview Actual Flutter widgets at phone width with synthetic data and the new reply wiring disabled/enabled. These are widget-test captures, not installed-device or live-relay evidence. | Before | After | | --- | --- | | ![Activity omits the unmentioned reply](https://github.com/user-attachments/assets/a6fc8193-b1ef-4022-a5f1-a1cbbcdf5fb2) | ![Activity shows the unmentioned thread reply](https://github.com/user-attachments/assets/b2a6ba13-384a-4d0f-bda3-88d83307d31e) | ### Human validation pending Draft per the repository readiness checklist. On a device, receive an unmentioned reply in a thread you started, replied in, or followed. Check Activity → All and Threads, tap the row to reach the reply, then read it and confirm Unread clears without reading unrelated channel messages. Native/live-relay testing and human confirmation remain pending. --------- Signed-off-by: kenny lopez <klopez4212@gmail.com> Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Co-authored-by: Tom Brow <tomb@block.xyz> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

brow marked this pull request as ready for review November 6, 2026 19:44

brow requested a review from a team as a code owner November 6, 2026 19:44

brow temporarily deployed to codex-review November 6, 2026 19:46 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/inbox_item.dart Resolved

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

brow temporarily deployed to codex-review November 6, 2026 20:00 — with GitHub Actions Inactive

klopez4212 approved these changes Nov 6, 2026

View reviewed changes

github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

brow temporarily deployed to codex-review November 6, 2026 20:06 — with GitHub Actions Inactive

github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

brow temporarily deployed to codex-review November 6, 2026 20:13 — with GitHub Actions Inactive

klopez4212 self-requested a review November 6, 2026 20:13

klopez4212 approved these changes Nov 6, 2026

View reviewed changes

github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

Comment thread mobile/lib/features/activity/inbox_item.dart Resolved

brow temporarily deployed to codex-review November 6, 2026 20:21 — with GitHub Actions Inactive

github-actions Bot added codex-security-review-current The posted Codex security review matches its recorded range. and removed codex-security-review-current The posted Codex security review matches its recorded range. labels Nov 6, 2026

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

brow temporarily deployed to codex-review November 6, 2026 20:30 — with GitHub Actions Inactive

klopez4212 self-requested a review November 6, 2026 20:31

klopez4212 approved these changes Nov 6, 2026

View reviewed changes

github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart Resolved

brow merged commit 597a8d1 into main Nov 6, 2026
53 checks passed

brow deleted the activity-filters-ui branch November 6, 2026 20:41

brow mentioned this pull request Nov 6, 2026

fix(mobile): read only shown events from filtered Activity rows #9215

Merged

2 tasks done

klopez4212 mentioned this pull request Nov 9, 2026

fix(mobile): show observed thread replies in Activity #9286

Merged

Conversation

brow commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validation

Before merge

Uh oh!

brow commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

brow commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔐 Codex Security Review

Review Summary

Findings

[MEDIUM] Preserve hidden unread messages when marking filtered threads read

Notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

brow commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

brow commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brow commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brow commented Nov 6, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 6, 2026 •

edited

Loading

github-actions Bot commented Nov 6, 2026 •

edited

Loading

[MEDIUM] `Preserve hidden unread messages when marking filtered threads read`