镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(mobile): split escaped voice-note links into their own segment - #8940

Merged
brow merged 3 commits into
mainfrom
mobile-escaped-voice-note-segment
Nov 2, 2026
Merged

fix(mobile): split escaped voice-note links into their own segment#8940
brow merged 3 commits into
mainfrom
mobile-escaped-voice-note-segment

Conversation

@brow

@brow brow commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Follow-up to #8925, from a Codex finding there.

After #8925, message Markdown arrives with backslash escapes shielded, but imeta is keyed by plain URLs. Two lookups used the raw, still-escaped destination:

  • Bubble segmentation (bubble_segments.dart): an attachment link such as [voice.mp4](https://…/voice\_note.mp4) missed its imeta entry and stayed inside the text bubble, even though the link builder rendered it as an attachment. The fix unshields the URL before the lookup.
  • Trailing image gallery (extractTrailingImageGallery in message_gallery.dart): with two or more trailing images, an escaped destination kept its backslash, so the carousel loaded the wrong URL and lost the imeta alt text. The fix unescapes the destination the same way as the label beside it. Its callers in message_media_avatar.dart and message_skeleton_body.dart get the fix too. This gap was already on main.

Validation

  • The existing attachments stay outside bubbles and text order is preserved journey now uses an escaped destination with a plain imeta URL. The existing carousel journey now has one escaped image destination and taps it by its plain URL. Each fails with its fix reverted.
  • flutter analyze is clean and the full mobile suite passes (4151 tests).
  • Limitation: no simulator run. Both changes are key lookups, and the widget journeys exercise the rendered layout. The full-app run for the surrounding escape handling is recorded in fix(mobile): render Markdown backslash escapes #8925.

🤖 Generated with Claude Code

@square-tomb studio @claude
fix(mobile): split escaped voice-note links into their own segment
4996e40 
Bubble segmentation sees Markdown with escapes held as stand-ins, but
imeta is keyed by plain URLs. A voice-note link whose destination has an
escape, such as `voice\_note.mp4`, therefore missed its imeta entry and
stayed inside the text bubble even though the link builder rendered it as
audio. Unshield the URL before the lookup.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
@brow

brow commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T19:01:14.021353Z e588aba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brow
brow marked this pull request as ready for review November 2, 2026 18:45
@brow
brow requested a review from a team as a code owner November 2, 2026 18:45
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 2fd5c122e8bb6d826549d070cb918747a95432ac...e588abac225ae262cd96990a3bb9d34bdfa336a0.
A new review must complete for this exact range. When manual authorization
is required, a user with write access must comment exactly
@buzz-security-review e588abac225ae262cd96990a3bb9d34bdfa336a0 to authorize a new review.
Any previous review applies only to its recorded range.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Nov 2, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4996e40ee3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/test/features/channels/message_content_test.dart Resolved
@square-tomb @claude
fix(mobile): unescape trailing gallery image destinations
214160a 
extractTrailingImageGallery used the raw destination, so an escaped URL
like two\_2.png kept its backslash and missed its imeta entry once two or
more trailing images formed a carousel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
johnmatthewtennant
johnmatthewtennant approved these changes Nov 2, 2026
View reviewed changes

@johnmatthewtennant johnmatthewtennant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed 4996e40 with the complete teammate-review workflow (60 lenses, 120 outcomes). The escaped voice-note segmentation fix matches the rendering lookup; no correctness blockers introduced by this change. The separately reported gallery gap predates this patch and is accepted for a later push. No Flutter tests or device journey run by me.

@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 2, 2026
@square-tomb @claude
test(mobile): fold escaped attachment case into the bubble journey
e588aba 
Per review, cover escaped attachment segmentation in the existing
attachments-stay-outside-bubbles journey instead of a standalone test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
@github-actions github-actions Bot added codex-security-review-current The posted Codex security review matches its recorded range. and removed codex-security-review-current The posted Codex security review matches its recorded range. labels Nov 2, 2026
@brow

brow commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: e588abac22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

johnmatthewtennant
johnmatthewtennant approved these changes Nov 2, 2026
View reviewed changes

@johnmatthewtennant johnmatthewtennant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed e588aba with the complete teammate-review workflow (62 lenses, 124 outcomes). The escaped attachment segmentation and gallery destination fixes match their rendering paths; no correctness blockers found. The existing bubble and carousel journeys cover the changed lookups. No Flutter tests or device journey run by me.

@brow
brow merged commit 35df866 into main Nov 2, 2026
53 checks passed
@brow
brow deleted the mobile-escaped-voice-note-segment branch November 2, 2026 19:18
brow pushed a commit that referenced this pull request Nov 2, 2026
@square-tomb studio @claude
fix(mobile): match desktop on tables, alerts and code spans
78b9c1a 
A real-message diff against desktop's parser found three differences:

- A table typed directly under a caption line showed raw pipes. GFM lets
  a table interrupt a paragraph; plusparse doesn't, so a blank line is
  inserted before such a table.
- `> [!NOTE]` quotes became alerts. Desktop has no alerts, so they stay
  quotes.
- An unclosed backtick run paired with a run in a later block, flipping
  later code and prose, so math-delimiter escapes leaked into code as
  entities. A code span now ends with its paragraph.

Bubble segmentation now unescapes a link destination itself before the
imeta lookup, since content no longer arrives shielded (#8940 relied on
that). Also pins gpt_markdown to exactly 1.3.4.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
@brow brow mentioned this pull request Nov 2, 2026
Draft
1 task
@saminsohag saminsohag mentioned this pull request Nov 4, 2026
Open
brow pushed a commit that referenced this pull request Nov 4, 2026
@square-tomb studio @claude
fix(mobile): match desktop on tables, alerts and code spans
503e941 
A real-message diff against desktop's parser found three differences:

- A table typed directly under a caption line showed raw pipes. GFM lets
  a table interrupt a paragraph; plusparse doesn't, so a blank line is
  inserted before such a table.
- `> [!NOTE]` quotes became alerts. Desktop has no alerts, so they stay
  quotes.
- An unclosed backtick run paired with a run in a later block, flipping
  later code and prose, so math-delimiter escapes leaked into code as
  entities. A code span now ends with its paragraph.

Bubble segmentation now unescapes a link destination itself before the
imeta lookup, since content no longer arrives shielded (#8940 relied on
that). Also pins gpt_markdown to exactly 1.3.4.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>

This branch was previously deployed

1 inactive deployment
codex-review — e588abac Deployed Nov 2, 2026 by brow via Run Codex Security Review #11879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@johnmatthewtennant johnmatthewtennant johnmatthewtennant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brow @johnmatthewtennant @square-tomb