Repository navigation
feat(mobile): pair by pasting a pairing code into the community link field - #8735
Closed
johnmatthewtennant wants to merge 1 commit into
Closed
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
Desktop's "Copy pairing code" copies a nostrpair:// URI, but the only way to enter it on mobile was a hidden two-finger double tap. Pasting it into the community link field, which is visible, was rejected as an invalid address. That blocks pairing wherever there is no camera, such as the iOS simulator. The community link input now passes a nostrpair:// code through, and the pairing page hands it to the same handler a scanned QR code uses, in both first-run onboarding and Add community. No new visible entry is added: onboarding's QR-first choice (and the hidden pairing option) is a deliberate product decision from #8599. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Tennant <jtennant@squareup.com>
Contributor
Author
|
🤖 Closing: the existing developer double-tap on Scan a QR code already covers simulator pairing, and onboarding stays QR-first. |
johnmatthewtennant
deleted the
jtennant/oliver/mobile-paste-pairing-code
branch
October 30, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop's Pair mobile dialog offers Copy pairing code (a
nostrpair://URI), but mobile onboarding had nowhere obvious to put it: pasting it into the community link field was rejected as an invalid link. A device without a usable camera, such as the iOS simulator, could only pair through the hidden developer gesture.The community link field now accepts a
nostrpair://code, on first-run onboarding and in Add community, and hands it to the same path a scanned QR code takes, including the recovery-mode checks. No visible "Enter pairing code" control is added.Product decision needed: #8599 made onboarding QR-first and kept manual pairing as a hidden developer option with "no keyboard path by design". This PR adds a keyboard path through the existing link field. It should not merge without sign-off on that intent.
Related issue
#8599 (the QR-first decision this revisits).
Testing
pairing_page_test.dartwidget test pastes anostrpair://code into the link field on both onboarding and Add community and asserts pairing starts with that code. Fails on main (Actual: []).community_link_input_test.dartnow expectsnostrpair://to pass through instead of being rejected.