Repository navigation
[buzz-app] Keep the sidebar in place when switching to Personal space - #945
Merged
Merged
Conversation
The non-ready channel sidebar wrapped its brand mark and page rows in .sidebarScroll, which had no top padding, no gap and no row inset. In Personal space the rows sat 10px higher and 4px further left than in a community, so switching communities shifted the sidebar. Render the non-ready sidebar and the error fallback in the same list structure as SidebarUnread, and inset Retry like a row so its focus ring stays inside the scrollport. Co-authored-by: Turtle <5154296422e91380cc199a47ba1a4f83683b61e3555c6f53a00c0e5a09f104ec@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Helen Tian <htian@squareup.com>
Use one feature-owned SidebarList for Personal space, connection and error states, and the community sidebar. Preserve the existing layout CSS, nav semantics, refs, unread overlays, and observer behavior. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Helen Tian <htian@squareup.com>
htian-dev
marked this pull request as ready for review
October 13, 2026 09:25
wesbillman
reviewed
Oct 13, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
No changes requested. Star Lord’s automated source review via Wes’s account, head 1a9d5cebc84002df351c8f89537453f83974a7fc, base 88575c007a7f423cf605318acc10d5a58753b896: the shared SidebarList preserves community navigation semantics, refs and unread overlays while aligning Personal space and recovery-state wrappers.
No tests or live UI checks were run; the hosted CI snapshot shows successful checks except skipped Windows native validation. Both attached videos downloaded but could not be decoded here, so their visual behavior and public-material privacy remain unverified.
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 14, 2026
* commit '506ac5d4d': Fix JPEG uploads and attachment control overlap (#1068) feat(channels): read, write and look up channel labels (#964) refactor(agents): separate the agent runner and its reads from the desktop app (#961) fix(media): show desktop animated avatars and match dev broker media rules to native (#990) ci(browser): split journeys across nine shards per engine (#989) test(inbox): open the edit journey's conversation by name (#997) test(voice-notes): keep each attachment's own type in the upload fixture (#999) Stabilize main: consolidate WebKit flake and bottom-follow fixes (#1039) Push main-pane threads in and hold threads behind a loading mark (#1018) [buzz-app] Show full sent images and GIFs (#886) feat(agents): say the agents this copy runs are online (#862) [buzz-app] Keep the sidebar in place when switching to Personal space (#945) fix(builderlab): link the Buzz key before attesting remote agents (#978) feat(agents): show agents typing to everyone while they work on a mention (#998) Signed-off-by: John Tennant <jtennant@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Switching from a community to Personal space moves the Buzz mark and page rows and widens their hover and selected fills.
Cause: Personal space used a separate scroll wrapper with different top padding, row gaps, and fill insets. The community sidebar already had the intended geometry.
Fix: One feature-owned
SidebarListnow supplies the frame, scrollport, and content wrappers for Personal space, connecting/error states, the error boundary, and the community sidebar. Both paths use the existing layout CSS. The community keeps its named navigation landmark, scroll/content refs, and unread overlays; unused.sidebarScrollCSS is removed. Retry channels retains room for its focus ring.For example, the Buzz mark sits 12px below the scrollport top and the first page row sits 34px below it in both spaces, instead of Personal space placing them at 4px and 24px.
Before
Screen.Recording.2026-10-13.at.7.20.37.PM.mov
After
Screen.Recording.2026-10-13.at.8.24.23.PM.mov