[matt2e]

Summary

On the Bestie page, ⌘F (Ctrl+F) opened nothing and ⌘K (Ctrl+K) had no "Search conversation with " row. PageSearch only recognised a conversation navigation target as the current conversation, and the Bestie page is a page target that presents the promoted Bestie DM.

PageSearch now derives the current channel from the conversation target's channel, or, on the Bestie page, from the shell's Bestie projection via useBestieConversation (provided by AppShell above it). That channel drives the ⌘F guard, the scoped search and ⌘K's "This conversation" row. Other page targets still open nothing with ⌘F. The header menu is out of scope.

Before / after

Left is main (58116b8), right is this branch. The fixture runs on Linux, so the shortcuts show as Ctrl+F and Ctrl+K. Both sides start on an ordinary DM with Ada, where Ctrl+F already works, then switch to the Bestie page ("Bestie · Pollen").

bestie-cmd-f-before-after.mp4

Ctrl+F on the Bestie page: main opens nothing (left); the fix opens a search scoped to Pollen that finds "gym" (right).

Ctrl+K on the Bestie page: main shows only Recent activity (left); the fix adds a "Search conversation with Pollen" row under This conversation (right).

Commits

• b5135e9 fix(search): make Command F search the Bestie conversation — PageSearch takes the current conversation from the conversation target or, on the Bestie page, from useBestieConversation; tests for ⌘F and the ⌘K row scoped to the Bestie DM, and for ⌘F opening nothing on another page; Bestie README and Buzz help updated.
• 2ea0ff5 refactor(search): name the Bestie page check and cover other conversations — adds isBestiePage(target) next to BESTIE_PAGE in bestie-context.ts, makes useBestieConversation require a session explicitly, and tests that ⌘F on another DM with a Bestie DM present scopes to that DM.
• 86f4ffc docs(bestie): mention Command K's conversation row on the Bestie page — Buzz help mentions the ⌘K "Search conversation with" row.

Testing

• Typecheck and lint pass.
• PageSearch, BestieNavigation and ChannelInventory suites: 119/119.
• Full vitest run: 20,060 passed, 27 skipped, 0 failed.
• Still to do: the native-app run that AGENTS.md requires (agent, then human). The reproduction and recording used a browser fixture with a device-local Bestie choice.

Related PRs

Open PRs #2775 and #2804 touch bestie-context.ts only cosmetically and do not conflict with this change.

🤖 Generated with Claude Code

[wesbillman]

🤖 Star Lord automated source review via Wes’s account.

Reviewed head 336d1840783f8e9a8261bf3dacdf4807d85561f3 against base/merge base 3a1eb5601e997811009d01601786df8af9393a7f.

No actionable findings in the reviewed change after independent Rocket, Mantis and Groot lanes plus Star Lord integration. The Bestie page reuses the shell’s exact-session DM projection for both Command F and Command K’s conversation row, while ordinary conversations retain precedence. Existing shortcut cleanup, search scope labels and dialog focus handling are preserved.

Source-only review: no tests, builds or app workflows were run. The public description and both screenshots were inspected; the video was not. The one-time CI snapshot still had checks running, and the PR explicitly lists native-app agent/human validation as pending. This comment does not establish runtime validation or approval.

[kazemek21]

Kyle reviewed the PR and the Nexus review-tracker notes and approved with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez