镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

test(solo): retry Solo agents through the mention menu in the tagging journey - #3016

Closed
loganj wants to merge 1 commit into
mainfrom
larry/fix-solo-agent-tagging-spec
Closed

loganj wants to merge 1 commit into
mainfrom
larry/fix-solo-agent-tagging-spec

Conversation

@loganj

@loganj loganj commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

🤖

Summary

Details

  • Test-only. No production code changes.
  • The journey keeps its purpose from test(solo): cover agent tagging behind a background read-state snapshot #2941: the agent list read must not wait behind a slow background read-state snapshot (the fix(solo): restore agent selection during slow background reads #2751 fix). With that fix reverted locally (agent list read on background priority), the journey fails: the agent is never addressed after Retry.
  • Retry suggestions calls the same agent list refresh as the removed notice's button.
  • After the connection gap, the journey refuses the first agent list read and holds any later one until the viewer has clicked Retry. Whether the reconnect rereads the list again (added in fix(agents): drop the Solo composer's inventory notice and reread partial failures #2948) depends on whether the chat is open when the connection returns, and that order differs between machines. A read that is held can't succeed or fail before Retry, so the journey passes or fails the same way in both orders.
  • While a reread is running, the mention menu shows "Loading recipients…" in place of the failure text, but it still offers Retry suggestions. The journey uses that option as its failure signal.
  • The journey also checks that every agent list read it lets through goes out at foreground priority, next to its existing check that the held snapshot is a background read.

🤖 Generated with Claude Code

… journey

#2948 removed the Solo composer's standing "Retry agents" notice; the
failure and its Retry now sit in the mention menu. #2941's journey still
waited for that notice, so it failed on main. Drive the same recovery
through the mention menu's "Retry suggestions" while the background
read-state snapshot is held.

Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj
loganj force-pushed the larry/fix-solo-agent-tagging-spec branch from e91686c to 81af325 Compare November 8, 2026 01:57
@loganj

loganj commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Superseded by #3015, which fixed this spec on main first (Retry through the Choose agent picker). Closing this one.

One note for whoever touches this spec next: the version on main still uses a single refuse-until-flip flag. The number of agent list reads after the gap is 1 or 2. It depends on whether the Solo chat is open when the connection returns, because the #2948 reconnect reread only fires when something holds the list. So a reread can either be refused but not yet settled when Retry is clicked (Retry joins it and no new read goes out), or arrive after the flip and clear Retry before the click. This PR's last commit (81af325) avoids both: it refuses one read and holds later ones until after the click. Its CI passed, including the WebKit flake lane.

@loganj loganj closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant