镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(messages): size thread avatars like the timeline's - #2890

Merged
baxen merged 2 commits into
mainfrom
task/match-thread-avatars-to-timeli-75cb
Nov 7, 2026
Merged

baxen merged 2 commits into
mainfrom
task/match-thread-avatars-to-timeli-75cb

Conversation

@comp615

@comp615 comp615 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Thread replies showed 24px (small) avatars, while the main timeline shows 32px (default), about the height of a one-line bubble. Top-level thread and continuation rows now use the timeline size. They already reserve a 32px avatar column (.nestedAvatar, .messageGutter, --message-side-space), so the bubble and text don't move.

Nested replies (compactAvatar) move from 16px (tiny) to 24px (small), one step below direct replies. That keeps the levels distinct without the big drop to 16px, inside the same 32px column. Compact density already used default for both.

I checked this in the message gallery with its sample replies set to the thread layout and one reply nested: direct replies measure 32px, matching the root message, and nested replies measure 24px, with no overlap. I haven't checked it in the real thread panel, at narrow width, or in dark theme.

Before: 24px replies and 16px nested. After: 32px replies, matching the timeline, and 24px nested

🤖 Generated with Claude Code

@comp615
comp615 marked this pull request as ready for review November 6, 2026 22:41
@comp615
comp615 requested a review from a team as a code owner November 6, 2026 22:41
@morgmart

morgmart commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Design review: looks good. Thread replies now match the timeline avatar size.

One request from Morgan: please also bring nested replies up from tiny (16px) to small (24px). That gives 32px direct replies and 24px nested ones, so you can still tell the levels apart, but without the big jump down to 16. Nested avatars already sit in the same 32px column, so nothing else should move.

Not checked: I didn't run the app (this is from the code only), and I haven't looked at dark theme, narrow windows, or enlarged text.

@comp615

comp615 commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 @morgmart done in e325acc. Nested replies now use small (24px) instead of tiny (16px), so a thread shows 32px direct replies and 24px nested ones. They sit in the same 32px column, so nothing else moves. Compact density is unchanged and uses 32px for both.

I measured it in the message gallery with one reply nested: root 32px, direct reply 32px, nested reply 24px. The updated before/after is in the PR description. I haven't run it in the full app, and I haven't checked dark theme, narrow windows, or enlarged text.

comp615 and others added 2 commits November 7, 2026 03:11
Thread replies used 24px avatars while the timeline uses 32px, roughly one
bubble line. Thread rows already reserve a 32px avatar column, so they now
use the timeline size. Nested replies stay compact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Charlie Croom <ccroom@squareup.com>
Nested replies used 16px avatars, a big drop from the new 32px direct
replies. Per design review they now use 24px, which still separates the
levels inside the same 32px avatar column.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Charlie Croom <ccroom@squareup.com>
@comp615
comp615 force-pushed the task/match-thread-avatars-to-timeli-75cb branch from e325acc to 99ef66b Compare November 7, 2026 03:14
@baxen
baxen merged commit 6614b8b into main Nov 7, 2026
60 checks passed
@baxen
baxen deleted the task/match-thread-avatars-to-timeli-75cb branch November 7, 2026 04:11
tlongwell-block added a commit that referenced this pull request Nov 7, 2026
Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>

* origin/main:
  Build sidebar headings as one fluid design-system row (#2686)
  fix(messages): swap bubble fills for reactions you've made, drop the ring (#2949)
  fix(messages): align line-start mention capsules with each other (#2899)
  fix(relay): probe the live socket on wake, focus and network (#2958)
  fix(messages): size thread avatars like the timeline's (#2890)
  build(desktop): share the bundled buzz CLI build across worktrees (#2894)
  fix(messages): render review comment mentions as chips and open at the reader's place (#2965)
  feat(agents): read owner messages and canvases over MCP (#2881)

Signed-off-by: Tyler Longwell <tlongwell@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants