Repository navigation
test(mcp): cover renewal of a saved approval that includes create - #2654
Closed
wpfleger96 wants to merge 1 commit into
Closed
wpfleger96 wants to merge 1 commit into
wpfleger96 wants to merge 1 commit into
Conversation
A saved grant with read, post and create survives a serde round trip and renews with the same scopes. Renewal with different scopes is rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2650, which allowed saved external app approvals to include
create. That PR testedApproval::valid_scopes(), but nothing covered renewing a saved grant that includescreate.This adds one test in
src-tauri/src/host_mcp/pairing.rs. It uses the realGrantserde,reserve_atandrenew:read,postandcreatesurvives a serde round trip (the same encodingsaveandloaduse) and renews with exactly the same scopes and a new expiry.createalone, or the same scopes in another order) is rejected, and the expiry stays the same.Tests only. No production changes.
Checked:
cargo test --lib host_mcp::pairingpasses (11 tests). If the renewal check stops comparing scopes, the new test fails.