Repository navigation
fix(agent-harness): stop telling agents to use GitHub-flavored Markdown - #2639
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
joahg
left a comment
There was a problem hiding this comment.
🤖 One-line prompt wording change; no code impact.
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord automated source review via Wes’s account.
No actionable source findings in this one-line clarification. The wording matches the existing message renderer, which keeps raw HTML inert and displays tags as text; the shared raw prompt is consumed by both harnesses. Fenced-code guidance is preserved.
Reviewed head 2b823a2081f3b8a00d402ad6f8f8f23ab7f5cd99 against base a86ffc38991cffbc938daffb1ff61c1bc86b0592. Focused lead review of this routine wording change. Source-only: renderer, prompt loading/callers, existing test assertions, and PR description inspected; no tests, builds, app runs, or CI validation performed.
Buzz ignores raw HTML in messages, but the base prompt's GitHub-flavored Markdown line led agents to use GitHub-only HTML such as <details>, which showed up as literal tags. Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz>
2b823a2 to
27cf53e
Compare
* origin/main: (47 commits) fix(relay): report a community's membership refusal once, not as raw 403s (#3012) test(browser): fix red main and two cross-PR flakes (#3015) feat(agent-activity): keep remote agent outcomes readable (#2913) test(solo): cover agent tagging behind a background read-state snapshot (#2941) fix(desktop): quit on SIGTERM, SIGINT and SIGHUP so agents stop with Buzz (#2905) feat(unread): opening a channel quiets its sidebar row (#2998) fix(goose): end the turn when a final send succeeds (#2997) fix(relay): report a community's refusal once, not as raw 403s (#2978) Give fast Builderlab models their own section and a bolt in the model picker (#2592) feat(dev): `just desktop me` keeps Keychain approvals across rebuilds (#3002) fix(relay): show one quiet reconnect toast after 30 s, above the composer (#2968) feat(memory): render rich markdown and navigable buzz links (#2981) fix(identity): never strand first run on a key another account holds (#2996) Let agent_create propose instructions (#2332) fix(unread): raise a local read floor over dropped marks, and halve save validation (#2977) Add Codex huddle auto-join and thinking presence (#2927) feat(claude): set up Claude from a button beside Harness (#2975) docs(plugins): document the decisions API in the authoring guide (#2994) fix(agent-harness): stop telling agents to use GitHub-flavored Markdown (#2639) feat(identity): brand federated sign-in and return to the app (#2982) ... Signed-off-by: Tyler Longwell <tlongwell@squareup.com> Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/codex/voice.ts
Problem
The agent base prompt says "Use GitHub-flavored Markdown." Agents took that to mean GitHub-only HTML such as
<details><summary>would work. Buzz ignores raw HTML in messages (docs/channels.md), so the tags showed up as literal text. An agent that did this pointed to this line as the reason.Change
src/features/agent-harness/base_prompt.md: replace the line with "Use Markdown; raw HTML is not rendered." The guidance on fenced code blocks stays.Validation
Prompt text only.
base-prompt.tsimports the file raw. No other copy of the line exists in the repo (git grep).