镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

test: split Solo access browser scenarios - #2499

Merged
dr0uleau merged 1 commit into
mainfrom
nexus/keep-solo-sharing-browser-cases-within-their-tes-ef3f64e7
Nov 5, 2026
Merged

test: split Solo access browser scenarios#2499
dr0uleau merged 1 commit into
mainfrom
nexus/keep-solo-sharing-browser-cases-within-their-tes-ef3f64e7

Conversation

@dr0uleau

@dr0uleau dr0uleau commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

The Solo owner journey reaches the 120-second test deadline on hosted Linux WebKit. Its last enabled-state assertion gets only 653 ms of its 10-second budget.

What

Separate access saves and reloads from confirmation checks for joined viewers and existing Public chats. Keep every assertion and all four theme/layout presentations. Keep both engines, timeouts, and zero retries.

How

Each scenario gets fresh keys, relay state, storage, and a browser context. Worker builds remain shared. The save case checks eight signed edits. The confirmation case checks that cancellation sends no publications. Browser layout, focus, reload, and production broker wiring remain covered. No cases move to a lower layer.

Risk

Only one browser test file changes: +33/-4 lines. Production code stays unchanged. The file gains one case per engine and one fixture setup per engine.

Testing

On macOS arm64 Blox, run bin/pnpm test:browser tests/browser/solo-public-access.spec.mjs --project chromium --project webkit --no-deps --workers=2.

Evidence Base f51ecb16b Head 3232b3d80
Cases passed 6 8
Elapsed time 1.0 min 61.94 s
Sum of case durations 113.4 s 114.0 s
Slowest case 39.5 s 23.6 s
Worker build setup 2.60 / 2.87 s 2.46 / 2.64 s

The two owner cases take 21.9 / 16.3 s in Chromium and 23.6 / 15.2 s in WebKit. Temporarily remove the retained-access warning from ChannelGeneralAccess: the moved confirmation assertion fails in both engines with the missing warning. Restore the source byte for byte; the clean head passes all eight cases.

Independent agent review finds no blockers. sq agents review "origin/main...HEAD" rejects the range before review starts because routine dispatch does not support custom ranges. Local hooks and formatting pass. CI discovery confirms that every functional case remains selected exactly once. The broader integration run has one local setup failure; its focused rerun passes. The full rerun has the same setup failure (exit 11); its cause remains open.

Hosted Linux validation passes the Solo file. The WebKit shard passes all 70 cases in 420.0 s, with 770.1 s of summed execution. The Solo file takes 128.6 s in total; its owner cases take 47.4 and 37.3 s.

Ten repeated runs pass all 40 cases in each engine, without retries. Chromium takes 549.5 s elapsed / 1018.0 s summed execution; its slowest case takes 37.0 s. WebKit takes 1011.4 s elapsed / 1916.3 s summed execution; its slowest case takes 74.7 s. These runs establish bounded evidence on this head, not absence of all flakes.

The base includes the navigation test fix. At rebased head 0b5bd598f, all eight focused cases pass on macOS arm64 Blox in 61.85 s. The test diff matches the reviewed commit byte for byte. All hosted checks pass on rebased head 0b5bd598f. The local integration setup failure remains open; hosted integration passes on the earlier snapshot.

The author waives the human test for this test-only PR. Agent review and both-engine validation are complete. No native app or real-account flow runs. No Keychain prompt occurs.

buzz-review-completed

Generated with Codex

@dr0uleau
dr0uleau requested review from a team, gilgtm and kazemek21 November 4, 2026 21:55
@dr0uleau @codex
test: split Solo access browser scenarios
0b5bd59 
Co-authored-by: Codex <codex@openai.com>
Signed-off-by: Daniel Rouleau <drouleau@squareup.com>
@dr0uleau
dr0uleau force-pushed the nexus/keep-solo-sharing-browser-cases-within-their-tes-ef3f64e7 branch from 3232b3d to 0b5bd59 Compare November 5, 2026 00:01
@dr0uleau
dr0uleau marked this pull request as ready for review November 5, 2026 00:20
@dr0uleau dr0uleau mentioned this pull request Nov 5, 2026
Merged
kazemek21
kazemek21 approved these changes Nov 5, 2026
View reviewed changes

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle reviewed this PR and the Nexus review-tracker notes and approves with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@dr0uleau
dr0uleau merged commit b95f9df into main Nov 5, 2026
41 checks passed
@dr0uleau
dr0uleau deleted the nexus/keep-solo-sharing-browser-cases-within-their-tes-ef3f64e7 branch November 5, 2026 01:17
gilgtm added a commit that referenced this pull request Nov 5, 2026
@gilgtm
Merge remote-tracking branch 'origin/main' into gil/inbox-retry-cance…
d97fcea 
…lled-read

* origin/main: (28 commits)
  Run native Codex through plugin execution targets (#2150)
  test: split Solo access browser scenarios (#2499)
  feat(agents): let any agent change Buzz settings through the MCP (#2248)
  Let plugins decorate host sidebar rows and add sort modes (#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (#2083)
  feat(agents): move version history into settings (#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (#2465)
  feat(plugins): let agents request plugin changes for owner review (#2280)
  fix(messages): keep the hover toolbar while its menu is open (#2439)
  feat(workflows): suggest channel members for @ in Send Message text (#2309)
  AIDA-2344: Exclude muted channels from Dock (#2313)
  feat(search): add slack-style message search operators on desktop (#2463)
  test: fix invitation and coordination checks on main (#2517)
  perf(search): name searched people from the profile search response (#2353)
  Use the merge queue for pull requests that require it (#2452)
  fix(browser): load scheme-less address input over https, falling back to http (#2467)
  fix(identity): stop one-click key unlinks and show the linked backed-up key (#2486)
  fix(test): observe coordination transition events (#2297)
  ...

Signed-off-by: Gil Birman <gil@squareup.com>
Co-authored-by: Claude <noreply@anthropic.com>

# Conflicts:
#	docs/buzz-help.md
@AdamDonna AdamDonna mentioned this pull request Nov 5, 2026
Draft
1 task
cheng-block added a commit to cheng-block/buzz-app that referenced this pull request Nov 5, 2026
@cheng-block @cursoragent
Merge remote-tracking branch 'upstream/main' into cheng/fix-channel-s…
79024a0 
…ettings-shift-esc

* upstream/main: (91 commits)
  test(browser): click timeline rows only after the timeline settles (block#2560)
  ci: split Vitest across six shards so 3/4 stops hitting the job cap (block#2571)
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  fix(messages): keep the hover toolbar while its menu is open (block#2439)
  feat(workflows): suggest channel members for @ in Send Message text (block#2309)
  AIDA-2344: Exclude muted channels from Dock (block#2313)
  feat(search): add slack-style message search operators on desktop (block#2463)
  test: fix invitation and coordination checks on main (block#2517)
  ...

Signed-off-by: Cheng Peng <cheng@block.xyz>
Co-authored-by: Cursor <cursoragent@cursor.com>
cheng-block added a commit to cheng-block/buzz-app that referenced this pull request Nov 5, 2026
@cheng-block @cursoragent
Merge upstream/main to rerun CI against current main
5a3c2be 
* upstream/main: (22 commits)
  test(browser): click timeline rows only after the timeline settles (block#2560)
  ci: split Vitest across six shards so 3/4 stops hitting the job cap (block#2571)
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  fix(messages): keep the hover toolbar while its menu is open (block#2439)
  feat(workflows): suggest channel members for @ in Send Message text (block#2309)
  AIDA-2344: Exclude muted channels from Dock (block#2313)
  feat(search): add slack-style message search operators on desktop (block#2463)
  test: fix invitation and coordination checks on main (block#2517)
  ...

Signed-off-by: Cheng Peng <cheng@block.xyz>
Co-authored-by: Cursor <cursoragent@cursor.com>
cheng-block added a commit to cheng-block/buzz-app that referenced this pull request Nov 5, 2026
@cheng-block @cursoragent
Merge upstream/main to rerun CI against current main
8ef7a3c 
* upstream/main: (91 commits)
  test(browser): click timeline rows only after the timeline settles (block#2560)
  ci: split Vitest across six shards so 3/4 stops hitting the job cap (block#2571)
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  fix(messages): keep the hover toolbar while its menu is open (block#2439)
  feat(workflows): suggest channel members for @ in Send Message text (block#2309)
  AIDA-2344: Exclude muted channels from Dock (block#2313)
  feat(search): add slack-style message search operators on desktop (block#2463)
  test: fix invitation and coordination checks on main (block#2517)
  ...

Signed-off-by: Cheng Peng <cheng@block.xyz>
Co-authored-by: Cursor <cursoragent@cursor.com>
ljknight added a commit to ljknight/buzz-app that referenced this pull request Nov 5, 2026
@ljknight
Merge remote-tracking branch 'origin/main' into lauraknight/github-li…
bdfe17c 
…nks-in-browser

* origin/main: (138 commits)
  feat(composer): optional ⌘/Ctrl+Enter to send (block#2331)
  test: use keyboard activation for reply caret setup (block#2557)
  test: settle member search before invitation expansion (block#2532)
  test(agent-command): isolate the copied executable writer (block#2537)
  test(sidebar): wait for the rolled-back row to leave Starred before collapsing Work (block#2574)
  test(browser): click timeline rows only after the timeline settles (block#2560)
  ci: split Vitest across six shards so 3/4 stops hitting the job cap (block#2571)
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  ...

# Conflicts:
#	src/bundled/github/README.md
damienrj added a commit to damienrj/buzz-app that referenced this pull request Nov 5, 2026
@damienrj
Merge origin/main into claude/private-github-clone-auth-ab8b97
4d70569 
* commit 'a39dba132^':
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  fix(messages): keep the hover toolbar while its menu is open (block#2439)

Signed-off-by: damienrj <damien@squareup.com>
ljknight added a commit to ljknight/buzz-app that referenced this pull request Nov 5, 2026
@ljknight
Merge origin/main into lauraknight/quote-selection
24cc09a 
* origin/main: (121 commits)
  feat(composer): optional ⌘/Ctrl+Enter to send (block#2331)
  test: use keyboard activation for reply caret setup (block#2557)
  test: settle member search before invitation expansion (block#2532)
  test(agent-command): isolate the copied executable writer (block#2537)
  test(sidebar): wait for the rolled-back row to leave Starred before collapsing Work (block#2574)
  test(browser): click timeline rows only after the timeline settles (block#2560)
  ci: split Vitest across six shards so 3/4 stops hitting the job cap (block#2571)
  feat(github): unfurl PR and issue links inline with their title (block#1693)
  fix(auth): style federated sign-in callback pages (block#2549)
  fix(agents): align creation model controls with identity (block#2480)
  Run native Codex through plugin execution targets (block#2150)
  test: split Solo access browser scenarios (block#2499)
  feat(agents): let any agent change Buzz settings through the MCP (block#2248)
  Let plugins decorate host sidebar rows and add sort modes (block#1853)
  NEXUS-4082: Keep the new-message boundary stable during a visit (block#2083)
  feat(agents): move version history into settings (block#2374)
  fix(agents): read goose Activity by saved session ids and render memory bodies on open (block#2466)
  feat(channels): starter channels: admin switch and relay auto_join flag (block#1624)
  fix(plugins): read Square HTTPS sources with the Block SSH agent (block#2465)
  feat(plugins): let agents request plugin changes for owner review (block#2280)
  ...

# Conflicts:
#	docs/buzz-help.md
amlozano1 added a commit to amlozano1/buzz-app that referenced this pull request Nov 5, 2026
@amlozano1 @codex
Merge main and keep upstream Solo test split
60eaea1 
Adopt the landed Solo scenario split from block#2499 when reconciling the
same browser deadline fix, preserving all presentation and save coverage.

Co-authored-by: Codex <codex@openai.com>
Signed-off-by: Tony Lozano <tlozano@squareup.com>
@amlozano1 amlozano1 mentioned this pull request Nov 5, 2026
Open
@mahanti mahanti mentioned this pull request Nov 5, 2026
Merged
mahanti added a commit that referenced this pull request Nov 5, 2026
@mahanti bmo @codex
fix(sidebar): highlight collapsed sections with unread channels (#2539)
a707d41 
Collapsed sidebar sections currently hide the only indication that their
channels have unread messages. Highlight each collapsed heading with the
existing unread color and weight when its rendered channels have unread
messages or thread activity; confirmed-muted channels stay quiet.
Expanded headings retain their current treatment.

This reuses `SidebarSection`, `UnreadBadge` markers, and semantic unread
tokens, with no new unread state or subscriptions. Also updates the
bundled help guide.

Validation at `4aa3c606d`:
- Six browser checks passed in Chromium and WebKit: ordinary unread,
read clearing, mute/unmute, incoming messages while collapsed, thread
replies after reading the timeline, nested Team headings, keyboard
disclosure, both themes, narrow/wide sidebars, and enlarged text.
Existing heading geometry coverage also passed.
- Two new browser cases cover computed `:has()` styling through hidden
section content and app/broker integration; no cases removed. Removing
the CSS reproduces the original heading-color failure.
- Native macOS build compiled with federated identity; Arjun’s identity,
saved communities and channel inventory loaded. Exercised collapse and
confirmed unread color/weight; inspected a native screenshot. Live
writes/mute/read mutations were tested only with disposable browser
fixture identities.
- Mandatory commit/push checks passed, including type/related-test and
design-system lanes. Rust lane had no affected source. Independent
source review found no blockers (9/10 minimalness, elegance and
correctness).

Acceptance behavior: collapse a sidebar section containing unread
channels; its heading should highlight. Expanding restores its quiet
heading. Reading all eligible channels or muting them clears the
collapsed highlight. Individual Solo workspace disclosures are outside
this fix. The heading’s accessible label remains its existing title.


### CI repair update — November 5

Published `5238b8ce14f19feccb70e26c3fe19af726f97449`, merging `main` at
`5fd35b1916736551f0bc2bdad35b65676b4c043c`. This incorporates existing
upstream fixes #2532 (settle member search before pagination) and #2499
(split Solo access scenarios without dropping assertions). No new
production behavior or test changes beyond main were introduced; the
feature diff remains the original three files.

Validation of the merged tree: all 48 cases passed in Chromium and
WebKit (3.0 minutes, macOS, two workers) for
`channel-members-focus.spec.mjs`, `solo-public-access.spec.mjs`, and
`sidebar-collapsed-unread.spec.mjs`. Mandatory push checks passed.
Hosted CI: https://github.com/block/buzz-app/actions/runs/42080727880
(passed: 41 checks successful, including CI required and DCO; two
expected skips). No reviewer threads existed to address.

Arjun confirmed successful human testing on November 5. Agent review,
agent behavior checks, human acceptance, and current-head hosted checks
are complete.

buzz-review-completed

Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: bmo <a7b504d9a2bfe905589e9ac237d7d8d023b8d10547060ec9618e6487b55d756c@buzz.block.builderlab.xyz>
Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazemek21 kazemek21 kazemek21 approved these changes
@gilgtm gilgtm Awaiting requested review from gilgtm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dr0uleau @kazemek21