Repository navigation
Keep imported provider agents out of local connection setup - #2487
klopez4212 wants to merge 1 commit into
Conversation
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4764c9092
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .unwrap_or("buzz-agent") | ||
| }; | ||
| let runtime = if record["backend"]["type"].as_str() == Some("provider") { | ||
| let backend = if harness { |
There was a problem hiding this comment.
The reviewed commit message has no Signed-off-by trailer, so the repository’s hosted DCO check will fail even though local hooks passed. Recreate the commit with git commit --signoff before submitting it.
AGENTS.md reference: AGENTS.md:L217-L220
Useful? React with 👍 / 👎.
joahg
left a comment
There was a problem hiding this comment.
🤖 Fix is correct: imported harness records keep their backend under imported.record.backend, and both new tests cover it. The Codex P1 about a missing Signed-off-by is stale, since the commit carries the trailer.
Legacy harness imports store their provider backend under
imported.record.backend. Reading only the top-level backend classified these hosted agents as local harnesses, allowing the connection card to offer a local import after stale hosted presence disappeared.Read the backend from the persisted payload for harness imports, while retaining the top-level lookup for old Buzz records. Regression coverage checks known/custom harness commands and the portable-agent listing path.
Follow-up to #2423: #2423 (comment)
Validation: all 101 agent-controller tests passed; agent-controller Clippy passed; machine push policy checks passed. Source review confirms the existing connection card excludes the resulting
hostedruntime. Real native legacy import was not exercised. Ready for review as requested.