镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Make agent transcripts quieter and link finished replies to activity - #2424

Merged
mahanti merged 13 commits into
mainfrom
am-1103-agent-transcript
Nov 6, 2026
Merged

mahanti merged 13 commits into
mainfrom
am-1103-agent-transcript

Conversation

@mahanti

@mahanti mahanti commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Agent transcripts show an aligned sequence of individually expandable steps, with tool verbs leading each row, monospace inputs/outputs/diffs, and final replies in the shared received-message bubble. Terminal status rows preserve explicit failed, stopped, unknown, and completed outcomes. Active work retains a single typing/shimmer indicator.

  • Reuse shared avatars, typing dots, shimmer, message bubbles, and semantic status/type/spacing roles. Share one disclosure shell for tool and narrative rows; keyboard and reduced-motion interactions remain immediate.
  • Preserve Channel/Thread navigation in the aggregate published feed and omit redundant navigation in individually scoped adapter transcripts.
  • Show “View activity” beside eligible reply timestamps only after associated work and publication settle, including stopped and superseded work. Retain publication association separately from expiring notification correlation.
  • Preserve readable labels at narrow widths and enlarged text with the new dock: constrain quiet metadata, share profile content insets with the hero/footer, and size the portrait within its panel.
  • Give the fixed status red a single light-palette owner, reused by the light red ramp and status role. The color guard validates the exact binding and literal owner.

Validation

  • Independent review: no blockers, 9/10. Follow-up review covered the color guard and navigation fixture contract repair.
  • Explicit terminal-outcome regression: 7 failures with the old renderer; all 33 transcript/aggregate adapter tests pass with the repair.
  • Full affected browser file: 20/20 cases pass in Chromium and WebKit (26.7s). Existing journeys exercise 360/390px widths at 150%/200% text. Label-width and row-height assertions remain; the added panel-overflow assertion failed before the portrait fix and passes afterward. No browser cases added or removed. Real browser geometry is required for these layout contracts.
  • Synthetic browser exercise: pointer and keyboard expand/collapse, narrow/enlarged-text and wide layouts, light/dark captures. This does not establish native integration.
  • Design component suite: 201 tests across 28 files passed. Design viewer/message gallery builds and design TypeScript passed before the final CSS layout repair.
  • Hook follow-up: TypeScript and all 9 channel-context tests pass. The color guard passes and rejects both an invalid shared owner and an incorrect ramp binding. The context fixture now supplies main’s new PageNavigation.passThrough contract, matching sibling fixtures.
  • First full hook attempt: 8,692 passed and three failures. Fixed the merged prompt assertion to include author identity and replaced a transient picker-focus assertion with a menu-focus lifecycle barrier. Cleared Vitest’s stale filesystem transform cache, which omitted the newly merged Drafts & sent README from its glob. All 61 tests across the three affected files then passed; no README source change was needed.
  • Prior lifecycle regression coverage demonstrates replies retain activity links after notification expiry and nested replies do not inherit unrelated root completion. Mounted coverage includes remount/retry and pending-publication guards.

Acceptance and limitations

Arjun personally accepted expand/collapse, Channel/Thread navigation, settled-reply activity links, and narrow/enlarged-text layout on November 5. The November 6 dock/layout repair still needs a focused human recheck. Marked ready for review at Arjun’s explicit request on November 6; this state change does not attest completion of that recheck. Native identity/community loading was not reverified during this follow-up. Code-owner approval is still required; this PR has not been merged.

The reply shortcut requires locally tracked publication evidence retained in memory. It is intentionally hidden for remote/history-only replies, after app restart, or after bounded local-work retention drops the association. Existing profile/context-menu activity access remains available.

On published head a56b6ae7e, all mandatory push checks passed: TypeScript/related unit tests (562.13s), design types/guards (4.99s), formatting/icons, secret scan, and push policy checks. No checks bypassed. GitHub reports no merge conflicts; current-head hosted CI passed all 58 executed jobs: https://github.com/block/buzz-app/actions/runs/42218544020. On-demand Windows validation was skipped.

Main independently added the same navigation fixture repair during validation. GitHub’s merge checkout duplicated the method and failed lint in the first hosted run. Merged main #2783 and retained its single fixture entry; the focused 9-test file and complete mandatory push checks pass on a56b6ae7e. Fresh hosted CI passed all 58 executed jobs on the reconciled head.

mahanti and others added 2 commits November 4, 2026 09:06
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti

mahanti commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Actual transcript components with isolated synthetic data. No live conversations or identities. Temporary capture fixtures were removed before commit.

Updated captures at ad71402f21619bd7eee3bb0989504409275cabb6:

  1. Light/wide: aligned System prompt, document icon, inset section headers, and right-aligned elapsed time/timestamp.
    Aligned prompt sections and tool metadata

  2. Dark/narrow: failed status and expanded Input/Output panels.
    Failed transcript at narrow width

Earlier component captures at 131e09770, retained for the expanded final bubble and longer content:

Completed transcript with final message bubble
Failed transcript with longer tool content

Pointer expansion and keyboard collapse were exercised. Still images do not establish animation timing, reduced-motion behavior, or native app acceptance.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti marked this pull request as ready for review November 4, 2026 14:55
@mahanti
mahanti requested review from a team as code owners November 4, 2026 14:55

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Found regressions in published-feed navigation, terminal-state activity links, and enlarged-text layout. Required browser journeys also need updating.

Comment thread src/features/messages/MessageRow.tsx Resolved
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti marked this pull request as draft November 4, 2026 15:56
mahanti and others added 5 commits November 5, 2026 07:46
Preserve transcript presentation alongside current prompt records and saved-session activity lookup.

Co-authored-by: Codex <codex@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Preserve quiet transcript metadata and conversation links while subscribing to clock preference changes. Cover mounted timestamp updates.

Co-authored-by: bmo <a7b504d9a2bfe905589e9ac237d7d8d023b8d10547060ec9618e6487b55d756c@buzz.block.builderlab.xyz>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: bmo <a7b504d9a2bfe905589e9ac237d7d8d023b8d10547060ec9618e6487b55d756c@buzz.block.builderlab.xyz>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Use the label minimum as its flex basis and let it grow into remaining space, so metadata wraps without putting every leading element on its own line. Extend the existing real-app layout regression to 360px; both browser engines reproduced the 323.9px row before the fix.

Co-authored-by: bmo <a7b504d9a2bfe905589e9ac237d7d8d023b8d10547060ec9618e6487b55d756c@buzz.block.builderlab.xyz>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Integrate upstream #2633, which fixes the TypeScript failure shared by JavaScript, author-package browser tests, and CLI integration checks. Preserve transcript changes.

Co-authored-by: bmo <a7b504d9a2bfe905589e9ac237d7d8d023b8d10547060ec9618e6487b55d756c@buzz.block.builderlab.xyz>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti marked this pull request as ready for review November 5, 2026 18:37

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Previous findings are repaired. One non-blocking design-token maintenance issue remains.

@mahanti
mahanti marked this pull request as draft November 6, 2026 11:52
mahanti and others added 4 commits November 6, 2026 06:54
Retain explicit remote outcomes in the transcript status presentation. Link solid danger status to the light red palette primitive. Coordinate narrow agent-panel gutters, bound portrait width, and keep transcript metadata from consuming extra rows.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti marked this pull request as ready for review November 6, 2026 14:03
@mahanti
mahanti merged commit bf95bd6 into main Nov 6, 2026
62 checks passed
@mahanti
mahanti deleted the am-1103-agent-transcript branch November 6, 2026 15:41
wpfleger96 added a commit that referenced this pull request Nov 6, 2026
…leanup

* origin/main: (84 commits)
  Restore macOS Cmd-W window closing when no tab handles it (#2443)
  Make agent transcripts quieter and link finished replies to activity (#2424)
  fix(channels): wrap unread conversation stepping around the sidebar (#2682)
  fix(navigation): let bare buzz:// open Buzz without a broken-link notice (#2718)
  fix(inbox): open DM thread rows as the thread (#2587)
  test(channels): complete the context navigation fixture (#2783)
  fix(channels): open a thread's channel at its root message from the #channel link (#2377)
  fix(people): find people by a pasted npub or hex key (#2396)
  test(bestie): open the narrow long-history thread with clickRow (#2723)
  Account-first onboarding and sign-in recovery (#2579)
  fix(agents): scroll the avatar dock with a mouse wheel (#2567)
  fix(avatars): keep Done in view when the avatar popup is short (#2706)
  feat(messages): highlight reactions you've made (#2709)
  feat(usage): move Usage from the sidebar into Settings (#2742)
  fix(messages): keep a playing row mounted in the channel timeline (#2695)
  Fix plugin status declaration closure for author consumers (#2643)
  fix(navigation): keep empty new chats out of Back history (#1617)
  [buzz-app] Recover remote agent message outcomes (#2542)
  feat(messages): name background send destinations and attach the files that fit (#2406)
  feat(drafts): clear a draft from its row (#2725)
  ...

# Conflicts:
#	src/bundled/builderlab/adapter-type/Activity.test.tsx
tlongwell-block added a commit that referenced this pull request Nov 6, 2026
Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Co-authored-by: Tyler Longwell <tlongwell@squareup.com>
Signed-off-by: Tyler Longwell <tlongwell@squareup.com>

* origin/main:
  test(messages): wait for the row measurement frame before thread catch-up dwell (#2837)
  Keep agent coordination history readable after work finishes (#2454)
  test(mentions): serve the mentions fixture as a build so cold loads fit (#2776)
  test(browser): let a late publication land after its page closed (#2565)
  test(relay): wait for the verified owner before a guest edits an agent (#2413)
  test: wait for the companion default width measurement (#2750)
  test(browser): preserve conversation scroll while revealing actions (#2715)
  test(browser): wait for link hit-testing after thread close (#2792)
  perf(messages): skip micromark for plain prose bodies (#2780)
  perf(inbox): load the emoji name table on first use (#2774)
  perf(messages): cut main-thread work while a busy channel is open (#2729)
  Refine agent Attention cards, watch details, and status controls (#2717)
  fix(bestie): remove a Bestie from its agent card on any device (#2720)
  feat(agents): preview Builderlab agent card links with Add to Buzz (#2719)
  Restore macOS Cmd-W window closing when no tab handles it (#2443)
  Make agent transcripts quieter and link finished replies to activity (#2424)
johnmatthewtennant added a commit that referenced this pull request Nov 6, 2026
…ve-enter

* origin/main: (21 commits)
  Make drafts and sent part of Messages (#2728)
  fix(canvas): render every Canvas within the save limit (#2839)
  test(messages): wait for the row measurement frame before thread catch-up dwell (#2837)
  Keep agent coordination history readable after work finishes (#2454)
  test(mentions): serve the mentions fixture as a build so cold loads fit (#2776)
  test(browser): let a late publication land after its page closed (#2565)
  test(relay): wait for the verified owner before a guest edits an agent (#2413)
  test: wait for the companion default width measurement (#2750)
  test(browser): preserve conversation scroll while revealing actions (#2715)
  test(browser): wait for link hit-testing after thread close (#2792)
  perf(messages): skip micromark for plain prose bodies (#2780)
  perf(inbox): load the emoji name table on first use (#2774)
  perf(messages): cut main-thread work while a busy channel is open (#2729)
  Refine agent Attention cards, watch details, and status controls (#2717)
  fix(bestie): remove a Bestie from its agent card on any device (#2720)
  feat(agents): preview Builderlab agent card links with Add to Buzz (#2719)
  Restore macOS Cmd-W window closing when no tab handles it (#2443)
  Make agent transcripts quieter and link finished replies to activity (#2424)
  fix(channels): wrap unread conversation stepping around the sidebar (#2682)
  fix(navigation): let bare buzz:// open Buzz without a broken-link notice (#2718)
  ...
cheng-block added a commit to cheng-block/buzz-app that referenced this pull request Nov 6, 2026
…ime-hint

* upstream/main: (26 commits)
  Make drafts and sent part of Messages (block#2728)
  fix(canvas): render every Canvas within the save limit (block#2839)
  test(messages): wait for the row measurement frame before thread catch-up dwell (block#2837)
  Keep agent coordination history readable after work finishes (block#2454)
  test(mentions): serve the mentions fixture as a build so cold loads fit (block#2776)
  test(browser): let a late publication land after its page closed (block#2565)
  test(relay): wait for the verified owner before a guest edits an agent (block#2413)
  test: wait for the companion default width measurement (block#2750)
  test(browser): preserve conversation scroll while revealing actions (block#2715)
  test(browser): wait for link hit-testing after thread close (block#2792)
  perf(messages): skip micromark for plain prose bodies (block#2780)
  perf(inbox): load the emoji name table on first use (block#2774)
  perf(messages): cut main-thread work while a busy channel is open (block#2729)
  Refine agent Attention cards, watch details, and status controls (block#2717)
  fix(bestie): remove a Bestie from its agent card on any device (block#2720)
  feat(agents): preview Builderlab agent card links with Add to Buzz (block#2719)
  Restore macOS Cmd-W window closing when no tab handles it (block#2443)
  Make agent transcripts quieter and link finished replies to activity (block#2424)
  fix(channels): wrap unread conversation stepping around the sidebar (block#2682)
  fix(navigation): let bare buzz:// open Buzz without a broken-link notice (block#2718)
  ...

Signed-off-by: Cheng Peng <cheng@block.xyz>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants