Repository navigation
fix: exclude muted channels from sidebar unread scroll indicators - #2335
Merged
Merged
Conversation
laneysmith
marked this pull request as ready for review
November 3, 2026 22:35
salman1993
approved these changes
Nov 4, 2026
salman1993
left a comment
Contributor
There was a problem hiding this comment.
🤖 Reviewed by sol, Salman's AI agent, on his behalf at 7d7fc5310755c7e38d145a8956a2f93db8e00908.
No blocking findings. Confirmed mute state excludes both unread and thread markers before the sidebar derives counts, avatar previews, and reveal targets. The attribute observer handles mute/unmute changes without requiring another message, and the unread stores remain untouched.
Validation:
- All 14 sidebar browser checks passed across Chromium and WebKit.
- The two sidebar test files plus CommunityPicker passed on a focused rerun: 72 tests.
- Removing the mute filter made five regression cases fail; restoring it returned all 14 SidebarUnread tests to green. The working tree is clean.
- Full Vitest: 15,977 passed, 21 skipped, one failure in the unchanged
CommunityPicker.test.tsx:434right-click focus assertion. That entire file passed on rerun. Its test does not render the changed components, so I do not consider it a blocker for this fix. - Required CI and DCO are green at this head.
Native app and human acceptance remain pending, as documented in the PR. This review does not attest those checks.
laneysmith
force-pushed
the
laneys/fix-muted-unread-scroll-cue
branch
from
November 4, 2026 16:12
7d7fc53 to
ded24c9
Compare
Co-authored-by: Blue Raspberry Jello Canelé <417c271f0f8eb7d0c3eb9e706a364c84a9e938d7ac18621dc30185109fcaac49@buzz.block.builderlab.xyz> Signed-off-by: Laney Pouzet <laneys@squareup.com>
laneysmith
force-pushed
the
laneys/fix-muted-unread-scroll-cue
branch
from
November 4, 2026 18:46
ded24c9 to
be2c20a
Compare
gilgtm
added a commit
that referenced
this pull request
Nov 4, 2026
* origin/main: fix: exclude muted channels from sidebar unread scroll indicators (#2335) fix(claude-code): open long Claude transcripts a page at a time (#2428) feat(solo): share chats as view only (#2375) fix(inbox): show Solo responses under All, read live replies in the open conversation, describe toolbar badges (#2275) AIDA-2434: Show saved teams in mentions (#2339) AIDA-2455: Restore channel scrollbar dragging beside threads (#2436) feat(agent-protection): show the owner why a protection provider denied input (#2105) fix(search): show slow lookups beside their section headings (#2442) Align Bestie DM layout and unread state; speed up thinking shimmer (#2418) Send Claude, Pi and Goose history as exact records (#2088) fix(agent-activity): align the stopped note and show it after the agent's reply (#2441) fix(agents): stop orphaned Attention commands and prevent duplicate runs (#2448) Signed-off-by: Gil Birman <gil@squareup.com> Co-authored-by: Claude <noreply@anthropic.com> # Conflicts: # src/app/shell/PageNavigation.tsx
wpfleger96
added a commit
that referenced
this pull request
Nov 4, 2026
…-nip-fi * origin/main: feat(inbox): preview recent Inbox activity when hovering the sidebar row (#2347) Add collapsible Solo and Team sidebar sections (#2296) fix(codex): open long Codex transcripts a page of items at a time (#2259) Keep Solo model and effort choices per chat (#2342) feat(sidebar): smooth channel reordering with bounded motion (#2108) Connect legacy agents from DMs and channel mentions (#2423) fix: exclude muted channels from sidebar unread scroll indicators (#2335) fix(claude-code): open long Claude transcripts a page at a time (#2428) feat(solo): share chats as view only (#2375) # Conflicts: # src/app/shell/PrimarySidebar.tsx
damienrj
added a commit
to damienrj/buzz-app
that referenced
this pull request
Nov 4, 2026
…-clone-auth-ab8b97 * origin/main: (38 commits) feat(identity): decide a missing backup choice from community membership (block#2378) Offer Builderlab decisions in FI builds (block#2227) feat(inbox): preview recent Inbox activity when hovering the sidebar row (block#2347) Add collapsible Solo and Team sidebar sections (block#2296) fix(codex): open long Codex transcripts a page of items at a time (block#2259) Keep Solo model and effort choices per chat (block#2342) feat(sidebar): smooth channel reordering with bounded motion (block#2108) Connect legacy agents from DMs and channel mentions (block#2423) fix: exclude muted channels from sidebar unread scroll indicators (block#2335) fix(claude-code): open long Claude transcripts a page at a time (block#2428) feat(solo): share chats as view only (block#2375) fix(inbox): show Solo responses under All, read live replies in the open conversation, describe toolbar badges (block#2275) AIDA-2434: Show saved teams in mentions (block#2339) AIDA-2455: Restore channel scrollbar dragging beside threads (block#2436) feat(agent-protection): show the owner why a protection provider denied input (block#2105) fix(search): show slow lookups beside their section headings (block#2442) Align Bestie DM layout and unread state; speed up thinking shimmer (block#2418) Send Claude, Pi and Goose history as exact records (block#2088) fix(agent-activity): align the stopped note and show it after the agent's reply (block#2441) fix(agents): stop orphaned Attention commands and prevent duplicate runs (block#2448) ... Signed-off-by: damienrj <damien@squareup.com>
johnmatthewtennant
added a commit
that referenced
this pull request
Nov 4, 2026
* origin/main: (38 commits) fix(browser): load scheme-less address input over https, falling back to http (#2467) fix(identity): stop one-click key unlinks and show the linked backed-up key (#2486) fix(test): observe coordination transition events (#2297) fix(profiles): keep the next view's profile reads through a shrink (#2395) fix(channels): show Add and Send message errors above the Manage members list (#2421) fix(threads): keep reply hooks off agent activity bubbles (#2422) fix(channels): offer only Copy link in a not-joined preview's sidebar actions (#2425) test: scope row menu placement checks to active section rows (#2493) feat(relay): detach channel windows to a point in history (#2042) feat(identity): decide a missing backup choice from community membership (#2378) Offer Builderlab decisions in FI builds (#2227) feat(inbox): preview recent Inbox activity when hovering the sidebar row (#2347) Add collapsible Solo and Team sidebar sections (#2296) fix(codex): open long Codex transcripts a page of items at a time (#2259) Keep Solo model and effort choices per chat (#2342) feat(sidebar): smooth channel reordering with bounded motion (#2108) Connect legacy agents from DMs and channel mentions (#2423) fix: exclude muted channels from sidebar unread scroll indicators (#2335) fix(claude-code): open long Claude transcripts a page at a time (#2428) feat(solo): share chats as view only (#2375) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Muted conversations should not trigger the sidebar's floating unread notification.
Problem
Muted channels can retain invisible unread markers after their visible dots are suppressed. The scroll indicator still counts those markers, leaving a misleading “1 unread” notification.
Solution
Exclude confirmed-muted destinations from the scroll indicator's count and avatar previews, including DMs, Solo chats, mentions, manual unread and thread replies. Keep their unread state intact so unmuting restores the indicators.
Test Steps
bin/just desktopand use your configured Buzz account.Automated validation passed: 15,978 unit tests and 14 sidebar browser checks across Chromium and WebKit. A separate browser reproduction confirms the baseline retains “1 unread” after muting the only unread DM and this branch removes it. Native app and human acceptance remain pending.
Videos and Screenshots
Same synthetic browser fixture and 1440 × 500 viewport; before is the base commit and after is this branch.