[eeSeeGee]

Problem

#2004 stopped ordinary unread messages from showing on muted channels in the sidebar. The macOS Dock dot still counted them. So a muted channel with ordinary messages could keep the Dock dot on while the sidebar showed nothing unread.

Refs AIDA-2344. This fixes the muted-channel cause only; unread in archived or hidden channels and closed DMs can still light the dot and is not changed here.

Solution

The Dock dot now uses the same rule as the sidebar row. I moved that rule from useUnreadState into src/features/channels/channel-unread.ts, and both UnreadBadge and bindUnreadIndicator use it.

• A confirmed mute stops ordinary messages from lighting the dot. Manual unread and messages that need attention still light it.
• DMs and Solo chats ignore mute, as their sidebar rows do.
• The binding also follows sidebarPreferences, so muting or unmuting updates the dot without a new message.
• A mute change still in progress, or preferences not loaded yet, quiets nothing.
• No relay reads are added.

docs/notifications.md no longer says mute is deliberately ignored, and docs/buzz-help.md gets one line on mute and the Dock.

For reviewers: a mention in a muted channel lights the Dock dot, but the muted sidebar row stays quiet. Mute hides the row's dots, and the name isn't bolded for attention. This PR keeps the dot on for that case, because a mention is the one thing you'd want to see in a muted channel. Whether the muted row should show it is #2004's decision, outside this change.

#2184 changes how muted DMs are bolded (ordinaryUnread), not this rule, so muted DMs still light the dot either way. #2277 touches indicator-unread.ts too, so expect a small conflict.

Test steps

• New tests in src/features/notifications/indicator-unread.test.ts:
  • Ordinary messages in a muted channel stay off the dot, and unmuting and re-muting flip it with no new message.
  • Mentions and manual unread still light a muted channel.
  • Muted DMs and Solo chats still light the dot.
• Without the indicator-unread.ts change, the muted-channel test and the mention/manual-unread test both fail. The DM/Solo test passes either way, as it should, since that behavior is unchanged.
• Full vitest run on ccff73e: 886 test files passed and 7 skipped; 15,745 tests passed and 21 skipped.
• tsc --noEmit, biome, and the pre-commit and pre-push hooks pass.
• No browser test cases added or removed.
• An independent agent review found nothing blocking.
• Not done yet: checking the native macOS Dock.
  1. Mute a channel and have someone post an ordinary message in it. The Dock dot should stay off.
  2. Unmute it. The dot should appear.
  3. Mute it again and have someone @mention you there. The dot should appear.

🤖 Generated with Claude Code

[eeSeeGee]

🤖 Waiving the native macOS Dock check for this PR. The change only alters the boolean the host passes to the existing unread_indicator_set command; the native badge path is untouched and already works in the shipped app. The projection logic is covered by the new indicator-unread tests (the muted-backlog and mention/manual-unread cases fail on main and pass here), two independent full Vitest runs (15,745 passed), and green CI. I'll confirm the real-world behaviour in the next release.

[kazemek21]

Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.

— Posted by Codex (gpt-6.1-sol) on behalf of kylez

[eeSeeGee]

🤖 Closing as superseded by #2313, which fixed the same AIDA-2344 muted-channel Dock dot bug on main. The remaining differences here (mentions, manual unread, and muted DMs/Solo chats still lighting the dot) are policy choices, and #2313's "muted means quiet" stands. If muted-channel mentions should light the Dock dot, that belongs in a small separate PR. Thanks for the approval.