[matt2e]

Summary

Three tests left files behind. Two left temp dirs on every run, and 224 buzz-spool-ipc-* and 48 preview-* dirs had built up on one machine. The flake-check test could leave a fixture suite inside the repo after an interrupted run. That leftover then broke every later vitest run, pnpm check and lint in that worktree. No product code changes.

Temp dirs left on every run (first commit)

• Rust: isolated_agent_ipc_probe (src-tauri/src/relay/tests.rs) rooted its Spools at a new temp_dir()/buzz-spool-ipc-<uuid> dir that nothing removed. The parent test runs the probe twice on Unix, so each cargo test of src-tauri left two dirs. The root is now a TempDir that the probe owns, and it is removed when the probe returns or panics.
• Node: the three fixture tests in tests/integration/preview-feed.test.mjs never removed their mkdtempSync dirs, so each node --test tests/integration left three in /tmp. Each test now registers t.after cleanup, as prune-preview-releases.test.mjs does.
• Verified: relay::tests::real_ipc_restores_identity_signs_and_rejects_invalid_requests and node --test tests/integration/preview-feed.test.mjs both pass, and neither left a new dir behind.

A leftover flake-selection-* fixture broke later runs (second and third commits)

• Cause: the parameterized-selection test in flake-check.test.mjs writes a flake-selection-* suite into tests/fixtures/design-system/. The suite includes a test that throws if it runs. If a run was interrupted, the suite stayed behind. It was not gitignored, and three tools picked it up:
  • Vitest's include matched it.
  • tsconfig.design.json includes tests/fixtures/design-system. Its noUnusedLocals failed with TS6133 in design:typecheck and in the pre-push design hook.
  • biome.json has vcs.enabled: false, so biome check . and pnpm lint ignore .gitignore. They reported errors in the fixture.
• Why the fixture stays in the repo: the test calls the script's real listVitest, which runs vitest list from the repo root with vitest.config.ts. Vitest collects only files that its include globs match under the root. A file in /tmp listed [], even when named by its absolute path. A plain exclude does not work either, because Vitest also drops an excluded file that is named by exact path.
• Change:
  • .gitignore ignores tests/fixtures/design-system/flake-selection-*/.
  • vitest.config.ts excludes that pattern unless BUZZ_FLAKE_CHECK_FIXTURE is set, and keeps Vitest's default excludes. The test sets the variable for the Vitest processes it starts, and clears it in t.after.
  • tsconfig.design.json excludes the pattern.
  • biome.json force-ignores it with !! in files.includes.
  • No other repo-wide check needs the pattern. design:check, check-icons and the pre-push hook's guards pass with a leftover present. design:test includes only *.test.ts, and the fixture is .test.tsx.
• Verified:
  • node --test tests/integration/flake-check.test.mjs passes all 10 tests, so the opt-in reaches vitest list. The run left nothing in tests/fixtures/design-system/ or /tmp.
  • A probe copy of the fixture's cases.test.tsx and a result.json were placed in tests/fixtures/design-system/flake-selection-probe/. Before the third commit, design:typecheck failed with two TS6133 errors. biome check --error-on-warnings . failed with 2 errors and 2 warnings, all in the probe. After it, both pass, and so does biome lint --error-on-warnings .. tsc -p tsconfig.design.json --listFilesOnly lists all 53 fixture files outside the probe and none inside it.
  • A probe config with the same exclude pattern listed no tests for a fixture named by exact path. Without the opt-in, the test would therefore list nothing and fail its six-location assertion. That case was not run.

The third commit also corrects the spool TempDir comment in relay/tests.rs. It had said the dir is removed after the app drops. Tauri does not promise to drop managed state with the App, so the Spools may outlive the dir. The comment now says only that the probe owns the dir and removes it when the probe returns or panics.

Overlaps

#1115 edits vitest.config.ts, and draft #1286 edits biome.json. Both conflict with this PR in those files, and both already conflict with main elsewhere.

Verification scope

Only the commands listed above ran, on local macOS, on the source branch. The three commits were cherry-picked onto current main with no conflicts and unchanged patches. Git hooks were skipped for the push.

Remaining gaps

• The third commit's tests.rs change is comment-only and was not compiled or run.
• Hosted CI has not run yet. It is the first full run on this head.

🤖 Generated with Claude Code

[kazemek21]

Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

[wesbillman]

🤖 Star Lord’s automated source review via Wes’s account, integrating Rocket, Mantis and Groot coverage.

No actionable source defects found in the seven-file test-cleanup and discovery change. Reviewed the probe-owned spool directory, synchronous preview-test children and teardown, and the generated fixture’s opt-in/discovery exclusions across Vitest, TypeScript, Biome and Git. The public description and three commit messages were inspected; no attached images were present.

Reviewed head e2ce3e667de5c363f599aec9164de90d6ee7eb89 against base/merge-base 36a283b2386473130430890faa3b06c6e45d4a6b, using immutable Git objects.

Hosted CI run 41057009921 succeeded on merge 0e5eb6e7fc8ad6bb308245a37134bfdf3aca9259, whose parents are the reviewed base/head and whose tree matches the head. The three Vitest timing artifacts report 13,956 passed, 21 skipped and zero failures; maximum shard command wall time was 488.03s and summed test execution was 1,666.12s (overlapping execution). No before/after timing baseline was collected, so cost regression is unassessed. Windows native and both advisory flake lanes were skipped.

Source-only: no local tests, PR-code execution, app launch or interrupted-run reproduction. Cleanup on forced termination, native Windows behavior and human acceptance remain unverified. No approval or merge-readiness claim.