镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(codex): set up Codex in a dialog from the agent creation card, as Claude does - #1419

Merged
salman1993 merged 4 commits into
mainfrom
claude/codex-inline-styling-research-f2fdfa
Oct 20, 2026
Merged

fix(codex): set up Codex in a dialog from the agent creation card, as Claude does#1419
salman1993 merged 4 commits into
mainfrom
claude/codex-inline-styling-research-f2fdfa

Conversation

@salman1993

@salman1993 salman1993 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

In the New agent dialog, choosing Codex before it's installed or signed in now opens a setup dialog from the Model row, like Claude does. Before, Codex ran setup in the row itself: a small button with a raw output log underneath, pushed into the form.

Reported while setting up Buzz on a fresh laptop: "installing codex has a fairly different and slightly worse styling the claude (it doesnt do a modal it does it inline)".

What changed

CodexSignIn in src/bundled/codex/tabs.tsx now follows ClaudeSignIn:

  • The Model row shows only Install Codex or Sign in. Clicking it opens the shared Dialog and starts that step.
  • The dialog is titled Set up Codex while installing and Sign in to Codex for sign-in. It contains:
    • a status line
    • one action button, which stays the same element as Install turns into Sign in, so keyboard focus doesn't move
    • Cancel while a step runs, Check again otherwise
    • the ~130 MB download note
    • the output, folded into a Setup details accordion
  • Closing the dialog cancels the running step, as Claude's does. When Codex is ready, the dialog closes and the model picker appears.
  • The button is disabled while a step runs, so a second agent card can't open a competing dialog.
  • Claude's "Enter a code" field is left out, because codex login has no step where you paste a code.

The Agents page's Harness defaults row and the provider dialog are unchanged. This also doesn't fix the codex-home/auth.json conflict reported in the same thread; #1398 does.

Tests

  • I updated the four card tests in tabs.test.tsx that expected the inline layout so they now work through the dialog. They check:
    • only one dialog opens across two cards
    • a failed login or download stays visible in the open dialog under Setup details
    • focus stays on the action button when Install turns into Sign in
    • the dialog closes once Codex is ready
  • I added one test: closing the dialog stops the codex login process.
  • No browser (Playwright) tests were added or removed.

vitest run src/bundled/codex/tabs.test.tsx: 34 passed. Biome, tsc --noEmit and design:check pass, and the pre-commit and pre-push hooks passed.

Not yet checked

  • Desktop app: not run yet. The browser preview can't show this flow, because without the desktop host Codex reports that it runs only in the desktop app.
  • Display: not checked in light and dark themes, at narrow widths, or with larger text.
  • Agent review and human testing: neither has happened yet, so this stays a draft.

To try it with just desktop on a machine without Buzz's copy of Codex:

  1. Open New agent and pick Codex. The Model row should show only Install Codex.
  2. Click it. Set up Codex opens with the download note and Cancel, and the install starts.
  3. When the install finishes, the same dialog should change to Sign in to Codex.
  4. Finish signing in in your browser. The dialog should close and the Model row should show the Codex models.
  5. Also try closing the dialog in the middle of signing in. The New agent dialog should stay open, and the row should show Sign in again.

🤖 Generated with Claude Code

@salman1993 @claude
fix(codex): set up Codex in a dialog from the agent creation card, as…
3fdea73 
… Claude does

Codex's Install/Sign in on the New agent Model row ran inline, spilling a
raw setup log into the form. It now opens a "Set up Codex" / "Sign in to
Codex" dialog matching Claude's: status line, one action button that
keeps focus as Install becomes Sign in, Cancel or Check again, the
download note, and the output under Setup details. Closing the dialog
cancels the step; the trigger is disabled while a step runs so another
card cannot open a competing dialog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
@salman1993
salman1993 marked this pull request as ready for review October 20, 2026 16:58
@salman1993
salman1993 requested a review from a team as a code owner October 20, 2026 16:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T17:04:58.760247Z 3fdea73 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fdea73f73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/bundled/codex/tabs.tsx Resolved
Comment thread src/bundled/codex/tabs.tsx Resolved
salman1993 and others added 2 commits October 20, 2026 13:10
@salman1993 @claude
fix(codex): hold setup buttons through the readiness check and keep f…
d633609 
…ocus

A step's process ends before the check that follows it, which can still
find the step needed; the setup trigger and the dialog's action now wait
for that check, so neither starts a second install or sign-in meanwhile.
When Codex becomes ready the dialog and its trigger leave together, so
focus that was in them moves to the model field instead of the page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
@salman1993 @claude
fix(codex): hand focus to the model field once its models load
93c0891 
When sign-in finishes, setup reports ready while the provider is still
loading models, so the model picker is disabled. Chromium refuses focus
on a disabled control, which left focus on the page. Wait until the
check settles before moving focus to the picker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
@salman1993
Merge remote-tracking branch 'origin/main' into claude/codex-inline-s…
832f458 
…tyling-research-f2fdfa

# Conflicts:
#	src/bundled/codex/tabs.test.tsx
@salman1993
salman1993 merged commit 58edf98 into main Oct 20, 2026
37 checks passed
@salman1993
salman1993 deleted the claude/codex-inline-styling-research-f2fdfa branch October 20, 2026 19:00
wpfleger96 pushed a commit that referenced this pull request Oct 20, 2026
Duncan
Merge remote-tracking branch 'origin/main' into hayt/native-federated…
0ffbe2c 
…-sessions

* origin/main: (23 commits)
  Add Marketplace tab and shared agent profile panels (#1411)
  fix: publish scoped typing indicators from conversation composers (#1435)
  feat: add configurable composer and pane focus shortcuts (#1418)
  perf(messages): reuse captured video opening frames on remount (#1437)
  FOR OCT 22: let agents clone and push their channel's repository (#1324)
  perf(relay): keep row profile map identity while new authors load (#1431)
  perf: avoid redundant relay channel derivation (#1412)
  Normalize dialog sizing, headers, spacing, and motion (#1403)
  Polish agent activity pills and popover actions (#1429)
  feat(agents): ask to resume claude and codex turns stopped by reload or quit (#1235)
  test(sign-out): join listed paths with / so the tests pass on Windows (#1247)
  fix(deps): remove distrusted emsign certificate roots (#1436)
  fix(plugins): distinguish usage and costs from agent activity (#1392)
  refactor(design-system): extract named Appearance palettes and revise plugin gradients (#1339)
  fix(channels): cancel inert activity popover opens (#1426)
  fix(codex): set up Codex in a dialog from the agent creation card, as Claude does (#1419)
  Add community-local settings (#1363)
  Fix sidebar and pane header alignment (#1409)
  Show recorded Codex scripts in Activity (#1413)
  fix(agents): restore emoji avatars in the agent avatar picker (#1404)
  ...

# Conflicts:
#	crates/agent-controller/src/app_agent.rs
wpfleger96 added a commit that referenced this pull request Oct 20, 2026
Duncan @wpfleger96 Paul
Merge remote-tracking branch 'origin/main' into hayt/native-federated…
0a5f465 
…-sessions

* origin/main: (23 commits)
  Add Marketplace tab and shared agent profile panels (#1411)
  fix: publish scoped typing indicators from conversation composers (#1435)
  feat: add configurable composer and pane focus shortcuts (#1418)
  perf(messages): reuse captured video opening frames on remount (#1437)
  FOR OCT 22: let agents clone and push their channel's repository (#1324)
  perf(relay): keep row profile map identity while new authors load (#1431)
  perf: avoid redundant relay channel derivation (#1412)
  Normalize dialog sizing, headers, spacing, and motion (#1403)
  Polish agent activity pills and popover actions (#1429)
  feat(agents): ask to resume claude and codex turns stopped by reload or quit (#1235)
  test(sign-out): join listed paths with / so the tests pass on Windows (#1247)
  fix(deps): remove distrusted emsign certificate roots (#1436)
  fix(plugins): distinguish usage and costs from agent activity (#1392)
  refactor(design-system): extract named Appearance palettes and revise plugin gradients (#1339)
  fix(channels): cancel inert activity popover opens (#1426)
  fix(codex): set up Codex in a dialog from the agent creation card, as Claude does (#1419)
  Add community-local settings (#1363)
  Fix sidebar and pane header alignment (#1409)
  Show recorded Codex scripts in Activity (#1413)
  fix(agents): restore emoji avatars in the agent avatar picker (#1404)
  ...

Co-authored-by: Will Pfleger <wpfleger@block.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@kalvinnchau kalvinnchau kalvinnchau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@salman1993 @kalvinnchau