Repository navigation
fix(goose): stop posting replies the agent did not send - #1359
Merged
salman1993 merged 2 commits intoOct 20, 2026
Merged
Conversation
wpfleger96
force-pushed
the
hayt/harness-failure-messages
branch
from
October 19, 2026 20:25
0faf771 to
0cf78d0
Compare
This was referenced Oct 19, 2026
wpfleger96
force-pushed
the
hayt/harness-failure-messages
branch
from
October 19, 2026 20:32
0cf78d0 to
4c4454b
Compare
wpfleger96
force-pushed
the
duncan/acp-shared-client
branch
from
October 19, 2026 21:44
42746a0 to
3cfa0b7
Compare
wpfleger96
force-pushed
the
hayt/harness-failure-messages
branch
from
October 19, 2026 21:45
a595989 to
3a041ea
Compare
added 2 commits
October 19, 2026 17:58
Every agent is told its assistant text is not published and it must use send, so Goose posting the unsent final text published private narration and broke deliberate silence. Claude Code and Codex never post it; the text now stays in local activity for Goose too. Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
The no-post check ran after a fixed microtask flush, so a post made later in the report step could land after the assertion. Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
wpfleger96
force-pushed
the
hayt/harness-failure-messages
branch
from
October 19, 2026 21:59
3a041ea to
ada3f60
Compare
salman1993
approved these changes
Oct 20, 2026
salman1993
left a comment
Contributor
There was a problem hiding this comment.
🤖 Reviewed on Salman’s behalf. Looks good—thanks!
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ada3f60fb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wpfleger96
added a commit
that referenced
this pull request
Oct 20, 2026
Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goose no longer posts the final assistant text of a turn in which the agent never called
send,editorreact. That text now stays in the agent's local activity, as it already does for Claude Code and Codex.Stack (merge order), 2 of 3: #1227 (shared ACP client) → this PR → #1251 (generic ACP agent)
#1359 and #1251 each branch directly from #1227 and don't depend on each other.
Before: when a turn ended without a successful
send, Goose posted its last assistant text into the thread so the thread wasn't left waiting.Why it changes: every agent's instructions say its assistant text is not published to Buzz and it must use
send. Agents therefore write that text as private narration ("I've replied to Will") or reason about why no reply is needed, and Goose then posted it, including over a deliberate decision to stay silent. Claude Code and Codex never post unsent text, so the same agent behaved differently depending on its harness.After: a failed turn still posts the raw harness error exactly as before; only the unsent-text fallback is removed.
src/bundled/goose/runtime.test.tschecks that unsent text is posted nowhere and still reaches local activity.