Repository navigation
fix(agents): refuse stale-roster Saves and revise unfinished team Creates - #1318
Closed
wpfleger96 wants to merge 0 commit into
Closed
wpfleger96 wants to merge 0 commit into
wpfleger96 wants to merge 0 commit into
Conversation
wpfleger96
force-pushed
the
hayt/team-config-writes
branch
from
October 19, 2026 14:50
2577e37 to
a61df2e
Compare
wpfleger96
force-pushed
the
hayt/team-create-revision-fixes
branch
from
October 19, 2026 14:52
089c97a to
3418e77
Compare
wpfleger96
force-pushed
the
hayt/team-config-writes
branch
from
October 19, 2026 15:12
a61df2e to
df10982
Compare
Member
Author
|
🤖 Folded into #1281, which now carries both commits from this PR unchanged (head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Stack: #1226 → #1281 → this PR
Closes the two remaining gaps in revising an unfinished team Create, both required before team sync (
CONFIG_SYNC_ENABLED) is turned on.A Save is refused unless this team's roster was read for it, in step with the team's work.
refuseDroppingJoined()no longer trusts the cached discovery result. While a Create is unfinished, each Save reads the team's channel fresh (channels.find). A failed read, a created channel that can't be found, or a channel without a roster refuses the Save with "can't be read". It refuses dropping any of the owner's agents on that roster, or any member whose add was confirmed or may have been sent. That check and the revision of the Create's intent run as one step on the team's runner queue (runner.exclusive): earlier steps, including any add, settle first, and no step of the older intent can dispatch or replan between the check and the revision. Teams with no unfinished Create skip the queue and do no extra relay read.A Save from the team card revises the unfinished Create. While a Create for that team is unfinished,
editTeam()revises that Create's intent instead of starting a separate Edit, so its older intent can't add a dropped member back later. A stopped Create refuses the Save with "Resubmit or dismiss it", the same as a reopened one. Uncertain-send evidence stays on the Create.