镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(agents): refuse stale-roster Saves and revise unfinished team Creates - #1318

Closed
wpfleger96 wants to merge 0 commit into
hayt/team-config-writesfrom
hayt/team-create-revision-fixes
Closed

wpfleger96 wants to merge 0 commit into
hayt/team-config-writesfrom
hayt/team-create-revision-fixes

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

🤖 Stack: #1226 → #1281 → this PR

Closes the two remaining gaps in revising an unfinished team Create, both required before team sync (CONFIG_SYNC_ENABLED) is turned on.

A Save is refused unless this team's roster was read for it, in step with the team's work. refuseDroppingJoined() no longer trusts the cached discovery result. While a Create is unfinished, each Save reads the team's channel fresh (channels.find). A failed read, a created channel that can't be found, or a channel without a roster refuses the Save with "can't be read". It refuses dropping any of the owner's agents on that roster, or any member whose add was confirmed or may have been sent. That check and the revision of the Create's intent run as one step on the team's runner queue (runner.exclusive): earlier steps, including any add, settle first, and no step of the older intent can dispatch or replan between the check and the revision. Teams with no unfinished Create skip the queue and do no extra relay read.

A Save from the team card revises the unfinished Create. While a Create for that team is unfinished, editTeam() revises that Create's intent instead of starting a separate Edit, so its older intent can't add a dropped member back later. A stopped Create refuses the Save with "Resubmit or dismiss it", the same as a reopened one. Uncertain-send evidence stays on the Create.

@wpfleger96

Copy link
Copy Markdown
Member Author

🤖 Folded into #1281, which now carries both commits from this PR unchanged (head df1098233). Its description covers the fixes.

@wpfleger96 wpfleger96 closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant