Repository navigation
fix(agents): add effort to launch-boundary Goose test fixture - #1263
Closed
salman1993 wants to merge 1 commit into
Closed
salman1993 wants to merge 1 commit into
salman1993 wants to merge 1 commit into
Conversation
#1185 added GOOSE_LOCAL without `effort`, and #1250 made `effort` required on the Goose launch config. Each passed CI alone; together they break `tsc` on main. Use Goose's own default, `effort: ""`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8503378ad6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tsc --noEmitfails onmain, so every open PR's JavaScript CI jobs fail at "Lint and types" (failing main run):Two PRs that each passed CI on their own combined to cause this:
b4f484d6a) added theGOOSE_LOCALfixture withouteffort.1228d79c5) madeeffortrequired on the Goose launch config.Change
Add
effort: ""toGOOSE_LOCAL. This is Goose's own default (src/bundled/goose/runtime.ts), and the Claude fixture in the same file uses the same value. It's a test-only change; production types are unchanged.Testing
tsc --noEmitis clean on top ofccd1be519(current main).vitest run src/features/agents/launch-boundary.test.ts: 4 passed.🤖 Generated with Claude Code