Repository navigation
Highlight an already-open thread tab when reopening it - #1050
Merged
Merged
Conversation
morgmart
marked this pull request as ready for review
October 14, 2026 04:16
kalvinnchau
reviewed
Oct 14, 2026
kalvinnchau
left a comment
Contributor
There was a problem hiding this comment.
🤖 No actionable findings in the code-only review of 58922b9 against merge base 2caaffe. Reviewed reopening behavior, lifecycle and security boundaries. No tests or browser/native checks were run. Required CI was reported failing with unresolved WebKit failures; their relationship to this change is unestablished. Resolve those failures before merging. This is not an approval.
kalvinnchau
approved these changes
Oct 14, 2026
Keep repeated conversation openings visible without remounting tabs or drafts. Use the shared navigation-tab paint layer and preserve history, selection, and reduced-motion behavior. Co-authored-by: Carl (AI agent) <goose@block.xyz> Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
morgmart
force-pushed
the
morganm/thread-tab-flash
branch
from
October 14, 2026 21:00
58922b9 to
a13908e
Compare
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 15, 2026
…-drag * origin/main: (34 commits) fix(channels): resolve template agents from ready inventory (#922) [buzz-app] Fit uploaded videos to the relay's 4K envelope and name video rejections (#1129) feat(github): reveal the PR comment a link points at (#947) fix(messages): stop WebKit freeze from muted composer video previews (#1143) test(browser): fix route-unroute and virtua-hold webkit flakes (#1149) test(browser): let dnd-kit see its first resize before text shrinks (#1150) fix(previews): keep a hovered preview through scroll anchoring (#1138) Unify owned agent profile panels (#1083) feat(agents): import old Buzz teams from the Teams tab (#985) Mark Me chats as personal in the session description for remote agents (#1058) feat(messages): optional way to open buzz message links in a thread tab (#1113) Distinguish thread originals and tighten conversation spacing (#929) fix(buzz-mcp): page channel reads past the relay limit (#1131) fix(inbox): show a session's top-level timeline as one conversation (#1094) feat: reorder sidebar groups by dragging their headers (#1118) fix(avatars): request the cached relay thumbnail at every avatar site (#1054) fix(messages): soften quote styling and tighten spacing (#1098) fix(emoji): shrink and raise inline custom emoji (#1097) fix: follow host theme in media review chrome (#1117) Highlight an already-open thread tab when reopening it (#1050) ... Signed-off-by: John Tennant <jtennant@block.xyz> Co-authored-by: Claude Worker <f425b86c3b780d43f8d9cf1802429d04dd985bf92eac44fca9468b5ad3887c5e@buzz.block.builderlab.xyz> # Conflicts: # src/features/channel-navigation/ChannelSidebarDnd.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Opening a thread that already has a tab briefly highlights that tab, including when it is already selected. Repeated openings restart the cue, so the app visibly answers “it’s right here” instead of appearing to do nothing.
New tabs, ordinary tab switching, history restoration, and retained-tab remounts do not flash. This first version covers thread openings from conversations; sidebar activity and navigation-only openings are unchanged.
How it works
The existing thread-tab owner recognizes a repeated opening. The shared navigation-tab control paints the cue using existing neutral pressed colors and motion tokens, reveals an overflowed tab without changing focus, and removes the cue when its animation finishes. Only the decorative layer restarts—not the tab, its thread reader, or its reply draft. Reduced motion holds the tint briefly and removes it without fading.
Shared guidance, the component catalog, and the interactive tab specimen document the behavior.
Demo
Shared-tab specimen, light mode. This animation uses controlled playback of the actual shared cue; it is not a real community recording.
Verification
2caaffe25. The existing real-app reopen journey now observes painted feedback and animation completion; no browser cases were added or removed.The initial push hook hit load-sensitive timeouts and menu-interaction failures with its default concurrency. All 169 tests across the four failing files passed separately with two workers; the complete required push hook subsequently passed with that existing worker limit and unchanged assertions/timeouts.
Hosted CI supplies broad validation. Packaged native acceptance of the latest main integration, exhaustive overflow/narrow host combinations, and sidebar-only cue behavior are not established by this PR. Kept as draft pending hosted checks; no full local scan was run.