Skip to content

mpdupdate: add support for abstract sockets - #7044

Open
Kladki wants to merge 1 commit into
beetbox:masterfrom
Kladki:mpdupdate-abstract-socket
Open

Kladki wants to merge 1 commit into
beetbox:masterfrom
Kladki:mpdupdate-abstract-socket

Conversation

@Kladki

@Kladki Kladki commented Sep 19, 2026

Copy link
Copy Markdown

Description

Adds support for abstract sockets for connecting to MPD, as documented here

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@Kladki
Kladki requested a review from a team as a code owner September 19, 2026 15:24
@github-actions github-actions Bot added the mpdupdate mpdupdate plugin label Sep 19, 2026
@Kladki
Kladki force-pushed the mpdupdate-abstract-socket branch from f8b312c to e835e1d Compare September 19, 2026 15:28
@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.32%. Comparing base (488b13e) to head (e835e1d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
beetsplug/mpdupdate.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
- Coverage   77.33%   77.32%   -0.02%     
==========================================
  Files         163      163              
  Lines       21857    21859       +2     
  Branches     3372     3373       +1     
==========================================
- Hits        16904    16902       -2     
- Misses       4137     4141       +4     
  Partials      816      816              
Files with missing lines Coverage Δ
beetsplug/mpdupdate.py 30.00% <0.00%> (-0.89%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snejus snejus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for this?

@Kladki

Kladki commented Oct 1, 2026

Copy link
Copy Markdown
Author

I tried to add a test for this, but tbh I couldn't figure out how, sorry.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mpdupdate mpdupdate plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants