Repository navigation
Conversation
bubanko
force-pushed
the
fix/2712-batch-message-handlers-concurrency-bug
branch
from
October 30, 2026 15:58
6784aaa to
4c2d32a
Compare
Contributor
Author
|
I presume duplication is not a blocker for this—the reported code blocks were already duplicates, and resolving this would require a refactor effort which would be too big for a "fix" PR. @phipag, can we move forward with this or would you like me to try and resolve the duplication? |
Contributor
|
Hey @bubanko, the Sonar duplication is acceptable here. But can you take a look at the |
…essing Replicate the thread-safe `BatchItemFailure` collection implementation from the `processBatchInParallel(event, context)` method to the overloaded variant that additionally accepting an executor. Apply this fix to all three `BatchMessageHandler` implementations. Using a shared, unsynchronized `ArrayList` to collect `BatchItemFailure` instances can lead to lost failure items or cause a worker thread to fail with an `ArrayOutOfBoundsException` due to concurrent modifications corrupting the list's internals state. GitHub issue number: aws-powertools#2712
bubanko
force-pushed
the
fix/2712-batch-message-handlers-concurrency-bug
branch
from
November 2, 2026 10:15
4c2d32a to
1747296
Compare
|
Contributor
Author
|
Ah, yes. I don't know why I though the As for the unused |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Replicate the thread-safe
BatchItemFailurecollection implementation from theprocessBatchInParallel(event, context)method to the overloaded variant that additionally accepting an executor.Apply this fix to all three
BatchMessageHandlerimplementations.Using a shared, unsynchronized
ArrayListto collectBatchItemFailureinstances can lead to lost failure items or cause a worker thread to fail with anArrayOutOfBoundsExceptiondue to concurrent modifications corrupting the list's internals state.Issue number: #2712
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.