Atom doesn't recognize keyword: val as different than a normal param. #61

Activity

1. kevinsawicki

   added

   bug

   on Oct 6, 2014
2. kevinsawicki commented on Oct 6, 2014

   

   kevinsawicki

   on Oct 6, 2014

   Contributor

   More actions

   Any suggestions for how you'd like it to look?
3. envygeeks commented on Oct 6, 2014

   

   envygeeks

   on Oct 6, 2014

   ContributorAuthor

   More actions

   Personally in my head it was just tagging "keyword" class onto the already existing classes so that we could just do function.parameter.keyword {} (or even just parameter.keyword) when we highlight function arguments.
4. jeremyf commented on Jul 9, 2015

   

   jeremyf

   on Jul 9, 2015

   More actions

   @kevinsawicki I also think that adding "keyword" to the correspond classes would be great.
5. andrefreitas commented on Sep 28, 2015

   

   andrefreitas

   on Sep 28, 2015

   More actions

   Any update on this?
6. mamenama commented on Oct 30, 2015

   

   mamenama

   on Oct 30, 2015

   Contributor

   More actions

   Just added cd70667 to PR #113 which gives the symbols in the hash the class constant.other.symbol.hashkey.ruby consistent with other symbol hashkeys. Is this along the lines of what you were looking for? (We can tag it something else, I suppose, but I was trying to be consistent with other symbols - let me know)
7. envygeeks commented on Oct 30, 2015

   

   envygeeks

   on Oct 30, 2015

   ContributorAuthor

   More actions

   Thanks @mamenama! I think I would also add function.paramater to it as well!
8. mamenama commented on Oct 30, 2015

   

   mamenama

   on Oct 30, 2015

   Contributor

   More actions

   OK - added them in 41fb848 which is now also part of PR #113 - take a look and let me know if that's what you were looking for.
9. winstliu commented on Nov 18, 2015

   

   winstliu

   on Nov 18, 2015

   Contributor

   More actions

   Fixed by #113.
10. winstliu

    closed this as completedon Nov 18, 2015