Repository navigation
Conversation
Contributor
Author
|
cherry-pick-to: 24 |
|
Workflow Check completed successfully |
seifzadeh
force-pushed
the
master-issue-1955
branch
from
September 25, 2026 21:15
5e581de to
731eab8
Compare
github-actions
Bot
dismissed
their stale review
September 25, 2026 21:39
Pull Request Checklist Complete
|
Workflow Check completed successfully |
jcolp
requested changes
Sep 28, 2026
| } | ||
|
|
||
| /* | ||
| * PJPROJECT only invokes the receive-data callback for application data |
Member
There was a problem hiding this comment.
This is incorrect. We explicitly disabled such pjnath functionality because it conflicted with our own functionality and caused issues. Any sender would get through here.
Contributor
Author
There was a problem hiding this comment.
thanks, i try to fix this report
Contributor
Author
There was a problem hiding this comment.
I updated the PR based on your feedback and tested it. Thanks.
When ICE moves media to another valid candidate pair, Strict RTP can remain locked to the previous source and drop media from the new path. Restart Strict RTP learning when PJPROJECT accepts RTP from a different source after Strict RTP has closed. Assisted-by: OpenAI ChatGPT Resolves: asterisk#1955 UserNote: Strict RTP now handles media moving between valid ICE paths.
seifzadeh
force-pushed
the
master-issue-1955
branch
from
October 25, 2026 20:05
731eab8 to
b8a3656
Compare
|
Workflow Check completed successfully |
jcolp
requested changes
Nov 11, 2026
|
|
||
| if (transport_rtp->ice && transport_rtp->ice_media_started | ||
| && transport_rtp->ice_active_remote_candidates | ||
| && read_area == transport_rtp->rawdata + AST_FRIENDLY_OFFSET) { |
Member
There was a problem hiding this comment.
Add a comment here to explain that the read_area check is to do with the buffering
| if (candidate) { | ||
| /* Tentatively pass this packet to SRTP authentication. | ||
| * The Strict RTP lock changes only after unprotect succeeds. | ||
| */ |
Member
There was a problem hiding this comment.
I think this deserves a debug message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ICE moves media to another valid candidate pair, Strict RTP can
remain locked to the previous source and drop media from the new path.
Restart Strict RTP learning when PJPROJECT accepts RTP from a different
source after Strict RTP has closed.
Assisted-by: OpenAI ChatGPT
Resolves: #1955
UserNote: Strict RTP now handles media moving between valid ICE paths.