镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

TINKERPOP-3260: Browser testing for gremlin-javascript - #3674

Open
Iryna-Kahamlyk wants to merge 7 commits into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3260
Open

Iryna-Kahamlyk wants to merge 7 commits into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3260

Conversation

@Iryna-Kahamlyk

@Iryna-Kahamlyk Iryna-Kahamlyk commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/TINKERPOP-3260

Summary

Adds two-tier smoke testing:

  • Tier 1: Bundles the package and verifies that it loads successfully in headless Chromium, catching Node-only imports at build time.
  • Tier 2: Verifies that browser transport can successfully round-trip HTTP requests to a real Gremlin Server.

Comment thread gremlin-js/gremlin-javascript/test/browser/serve.mjs Fixed
@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.71%. Comparing base (a28cd1f) to head (590dc7d).
⚠️ Report is 732 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3674      +/-   ##
============================================
+ Coverage     76.35%   76.71%   +0.35%     
- Complexity    13424    14345     +921     
============================================
  Files          1012     1037      +25     
  Lines         60341    64819    +4478     
  Branches       7075     7704     +629     
============================================
+ Hits          46076    49728    +3652     
- Misses        11548    11995     +447     
- Partials       2717     3096     +379     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

testMatch: 'live-roundtrip.spec.ts',
use: {
...devices['Desktop Chrome'],
launchOptions: { args: ['--disable-web-security'] },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't do this as this is actually the best way to test Gremlin Server's CORS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants