Repository navigation
Conversation
difin
force-pushed
the
addendum_asynchttpclient_upgrade
branch
from
November 6, 2026 00:05
e066a02 to
b58784a
Compare
difin
force-pushed
the
addendum_asynchttpclient_upgrade
branch
from
November 6, 2026 00:10
b58784a to
abae931
Compare
abstractdog
approved these changes
Nov 6, 2026
abstractdog
left a comment
Contributor
There was a problem hiding this comment.
LGTM
for clarity's sake, can you check what netty version is brought with the new async client? as far as I can recall, it uses netty
Contributor
Author
|
Hi @abstractdog, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.