Repository navigation
Conversation
…ow maven to build the planet-business module. Note these are present in the SVN repo so I'm wondering if they were removed when the repo was moved to GitHub as Git doesn't allow empty directories (hence the empty .gitignore file in each directory)
…cating it through the ${settings.localRepository} property.
…ow maven to build the weblogger-business module. Note these are present in the SVN repo so I'm wondering if they were removed when the repo was moved to GitHub as Git doesn't allow empty directories (hence the empty .gitignore file in each directory) Also updated main .gitignore to ignore weblogger-web/roller-startup.log which is produced by Maven at build time.
|
Hi, Just wondering if there's any feedback on this pull request as I notice it hasn't been looked at in over 5 months. Happy to discuss if there's something wrong with the change? Cheers, Edd |
|
Hi Edd, Thanks for the PR and sorry to have kept you waiting for long time. It looks like Apache Roller team seldom check GitHub. I've filed the one causing the Maven build to fail https://issues.apache.org/jira/browse/ROL-2086 , And I would start working to fix it. As for making use |
|
Hey, No worries, thanks for getting back to me and for raising ROL-2086. Cheers. Edd |
|
Hi Edd, I've just committed the fix of Thank you again for the contribution, Kohei |
…tpage Prevent annoying scrolling in EntryEdit page Thanks!
Hi all,
These commits add some empty directories (which were causing the Maven build to fail) which I think were deleted (Git doesn't support empty directories) when the apache svn repo was moved in to GitHub. I have re-created them each containing a single, empty .gitignore file which allows Git to persist them.
Secondly I have changed the way the local Maven repo is looked up, it was previously hard coded to look in the default location, it now takes the value from the user's settings.xml so it can pick up an overridden value if there is one, else will still use the default if not set in settings.xml
Hope this is helpful - a 'mvn clean install' now completes successfully from a fresh GitHub fork without it being necessary to make any modifications which should be encouraging to new roller users.
Cheers,
Edd