Repository navigation
Conversation
Signed-off-by: zjncs <18910855655@163.com>
zjncs
marked this pull request as ready for review
September 5, 2026 09:29
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Correct fix — the original code treated empty checkpoint as invalid and would skip writing it, causing stale data to persist. An empty checkpoint is a valid state that should be persisted.
Changes:
write(): Removed the early return for empty entriesread(): Check file existence instead of content emptiness to decide fallback
The test validates that writing an empty list after a non-empty one correctly returns empty on read.
LGTM.
Automated review by github-manager-bot
This was referenced Oct 20, 2026
[Bug] CheckpointFile skips valid backup recovery when the primary numeric header is malformed
#11460
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10863
CheckpointFile now writes a valid zero-entry checkpoint instead of ignoring an empty list. Reading falls back to the backup only when the primary is missing or invalid, so a valid empty primary cannot resurrect stale backup entries.
Added regression coverage for overwriting a populated checkpoint with an empty state.
Verification: git diff --check passed; Maven unavailable locally, CI should run CheckpointFileTest. AI-assisted contribution.