Repository navigation
[wip][fix][fn] Add function name and id to producer name to avoid conflict - #21912
Closed
jiangpengcheng wants to merge 1 commit into
Closed
jiangpengcheng wants to merge 1 commit into
jiangpengcheng wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your fix. I have a question. After adding the instance name to producerName, can the effectively_once be guaranteed? For example, there was no ack for the message before the failure, but the message was resent after switching to another instance. I think deduplication is invalid at this time because of different producerNames. @jiangpengcheng |
Contributor
Author
|
@graysonzeng hm, you are right, let's consider an another way to fix the issue |
Technoboy-
approved these changes
Jan 21, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21912 +/- ##
============================================
- Coverage 73.60% 72.39% -1.21%
+ Complexity 32359 32030 -329
============================================
Files 1859 1861 +2
Lines 138373 143467 +5094
Branches 15160 16278 +1118
============================================
+ Hits 101853 103870 +2017
- Misses 28640 31483 +2843
- Partials 7880 8114 +234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
freeznet
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21911
Main Issue: #xyz
PIP: #xyz
Motivation
there will be producer name conflicts error when function enable effectively_once and subscribed to a partitioned input topic
Modifications
Add functionId and instanceId to the suffix of the producer name to avoid conflicts
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#21