镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[FEATURE]Add wheel build script for macOS - #19957

Open
access2rohit wants to merge 1 commit into
apache:v1.xfrom
access2rohit:v1.x
Open

[FEATURE]Add wheel build script for macOS#19957
access2rohit wants to merge 1 commit into
apache:v1.xfrom
access2rohit:v1.x

Conversation

@access2rohit

@access2rohit access2rohit commented Feb 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds script to automate macOS wheel build process. (one script launch process)

Checklist

Essentials

  • PR's title starts with a category
  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented

@access2rohit
access2rohit requested a review from szha as a code owner February 25, 2021 21:29
@mxnet-bot

mxnet-bot commented Feb 25, 2021

Copy link
Copy Markdown

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, windows-gpu, centos-cpu, miscellaneous, centos-gpu, unix-cpu, unix-gpu, edge, sanity, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@access2rohit

access2rohit commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

@josephevans @leezu @szha please review

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 25, 2021
@access2rohit access2rohit changed the title [FEATURE]Adding wheel build script for macOS [FEATURE]Add wheel build script for macOS Feb 25, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 25, 2021
leezu
leezu reviewed Feb 26, 2021
View reviewed changes

@leezu leezu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the relation to https://github.com/apache/incubator-mxnet/blob/master/.github/workflows/os_x_staticbuild.yml ? Should there be any shared code?

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 26, 2021
@szha szha mentioned this pull request Apr 5, 2021
Open
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 14, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Mar 14, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 9, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 4, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner
@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham
@marcoabreu marcoabreu Awaiting requested review from marcoabreu
1 more reviewer
@leezu leezu leezu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-testing PR is reviewed and waiting CI build and test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@access2rohit @mxnet-bot @leezu @lanking520 @mseth10