镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

feat(vermeer): provides Vermeer project for the Go version of algorithms - #311

Closed
Skittles258 wants to merge 3 commits into
apache:masterfrom
Skittles258:master
Closed

Skittles258 wants to merge 3 commits into
apache:masterfrom
Skittles258:master

Conversation

@Skittles258

@Skittles258 Skittles258 commented Aug 23, 2024 •

Copy link
Copy Markdown
Contributor

Purpose of the PR

  • feat: provide go version of vermeer algorithm

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature labels Aug 23, 2024
logrus.Errorf("get uint start_key err:%v", err)
return err
}
hgl.startKey = uint32(startKey)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uint32 without an upper bound check.
logrus.Errorf("get uint end_key err:%v", err)
return err
}
hgl.endKey = uint32(endKey)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uint32 without an upper bound check.
return
}

task, err := taskBiz(ctx).GetTaskInfo(int32(taskID))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check.
}

//任务调度器取消任务
err = taskBiz(ctx).CancelTask(int32(taskID))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check.
}

//执行分页查询
resp.Vertices, resp.Cursor, err = taskBiz(ctx).QueryResults(int32(taskID), cursor, limit)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check.
return strconv.ParseInt(value, 10, 64)
case reflect.Uint:
uintValue, err := strconv.ParseUint(value, 10, 64)
return uint(uintValue), err

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uint without an upper bound check.
@javeme javeme changed the title feat(core): Provides the go version of the vermeer algorithm feat(vermeer): provides Vermeer project the Go version of algorithms Aug 24, 2024
@javeme javeme changed the title feat(vermeer): provides Vermeer project the Go version of algorithms feat(vermeer): provides Vermeer project for the Go version of algorithms Aug 24, 2024
@imbajin

imbajin commented Aug 27, 2024 •

Copy link
Copy Markdown
Member

@Skittles258 U could submit a tiny PR to modify little change (like modify one line in README) to avoid the permission limit of GitHub action

Also, we need provide more info for the vermeer's context (like apache/hugegraph#2265)

@Skittles258 Skittles258 closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants