Repository navigation
HIVE-30237: Clean up dependencies post thrift upgrade - #6938
dengzhhu653 wants to merge 2 commits into
Conversation
|
|
@InvisibleProgrammer @saihemanth-cloudera @Aggarwal-Raghav can you take a look please? Thank you! |
|
@dengzhhu653 , thank you for spotting this PR. I will check this today. |
| * This class serves as the super class for all handlers that implement the IHMSHandler | ||
| */ | ||
| public abstract class BaseHandler extends FacebookBase implements IHMSHandler { | ||
| public abstract class BaseHandler implements IHMSHandler { |
There was a problem hiding this comment.
I assuming this change is about picking up the code from FacebookBase and copying into this class so that fb303 can be removed. Am I correct?
If I am correct, are we still need fb303 at all?
I'm thinking about this: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/fb303.thrift
I only kept it to keep the compatibility and being able to remove fb303 completely later.
There was a problem hiding this comment.
We still need fb303.thrift, to register ProcessFunction that processes the request, such as shutdown()
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?