Repository navigation
Conversation
Contributor
Author
|
@ddekany when you have some time can we discuss this PR? as stated it only improves the test coverage for native support and does not change the codebase itself. |
Contributor
|
I haven't reviewed it yet, but I will eventually. But if you want to ask/tell something specific, go ahead of course. |
…st in CI - Expand HelloFreeMarkerTest with JUnit 5 test scenarios covering core directives, built-ins, lambdas, dynamic evaluation (?eval, ?eval_json, ?interpret), Java records, enums, static models, overloaded methods, member access policies, template loaders, output formats, custom directives/methods, and Properties-based configuration - Add template resources (features-suite.ftlh, included-header.ftlh, macro-lib.ftlh) and data model members to test #include, #import, macros, and functions in native image - Run :freemarker-test-graalvm-native:nativeTest in GitHub Actions CI workflow and document it in README.md Note: Generative AI (Google Gemini) assistance was used only for the isolated freemarker-test-graalvm-native test project, reviewed and refined by the author, and not used on the FreeMarker library code itself.
chore: updating ubuntu arm version to ubuntu 26.04 Following public preview actions/runner-images#14226 ubuntu 26 will substitute ubuntu 24 as latest tag too
fugerit79
force-pushed
the
4-increase-graalvm-native-image-test-coverage
branch
from
November 7, 2026 22:09
fe53e34 to
8af69a8
Compare
Contributor
Author
|
@ddekany basically this PR does not change the code base, as you can see from the file changed : https://github.com/apache/freemarker/pull/136/changes The PR only improve testing of Apache FreeMarker native usage, the only other modification is :
Additionally I switched the ubuntu arm version from 24 to 26, following the :
All has already been tested on the fork https://github.com/fugerit-org/freemarker/actions/runs/42419285594 repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the PR on graalvm-reachability-metadata to add Apache FreeMarker to the list of supported libraries, it was noted that:
This PR is linked to FREEMARKER-229 and aims to significantly increase GraalVM Native Image test coverage for Apache FreeMarker:
.javasuffixes infreemarker-core'sMETA-INF/native-image/org.freemarker/freemarker/reflect-config.jsonfreemarker-test-graalvm-nativewith a 17-test JUnit 5 native suite covering core directives, ranges/slicing, variadic/recursive macros and functions, built-ins, lambdas, dynamic evaluation (?eval,?eval_json,?interpret),BeansWrapper(Java records, enums, static models, overloaded methods, default/whitelist/blacklist/legacy member access policies), template loaders (#include,#import,auto_include,auto_import),TemplateConfigurationmatchers, output formats, custom directives/methods, custom number/date formats, arithmetic engines, exception handlers, XML DOMNodeModel,Properties-based configuration, and logger resolution:freemarker-test-graalvm-native:nativeTestin the GitHub Actions CI workflowA preview run of the PR has already been executed here: https://github.com/fugerit-org/freemarker/actions/runs/41204979908
Note: Generative AI (Google Antigravity / Gemini) assistance was used only for the isolated
freemarker-test-graalvm-nativetest project (and CI/README updates), reviewed and refined by the author, and not used on the FreeMarker library code itself. All the contributions have been reviewed and refined by the author.