Repository navigation
[Refactor][Framework] Refactor Extractors and Converters to use Generics #3616
Description
What and why to refactor
Extract functions use raw objects which they manually have to json-deserialize into predefined structs. This is needless boilerplate now that Go supports generics. Refactor the api_extractor.go (and other relevant framework files) to performs these deserializations under the hood and send the resulting Go structs to the user (Extract) functions.
The Converters suffer from this as well, although there's less boilerplate there. Refactor accordingly.
Describe the solution you'd like
Example:
currently we have:
Extract: func(row *helper.RawData) ([]interface{}, errors.Error) {
apiAccountOrgs := &[]GithubAccountOrgsResponse{}
err := json.Unmarshal(row.Data, apiAccountOrgs)
if err != nil {
return nil, errors.Convert(err)
}
simpleAccount := &SimpleAccountWithId{}
err = json.Unmarshal(row.Input, simpleAccount)
if err != nil {
return nil, errors.Convert(err)
}
// more logic...
}it should become like:
Extract: func(orgs []GithubAccountOrgsResponse, input *SimpleAccountWithId) ([]interface{}, errors.Error) {
// more logic...
}The API extractor will need to take two generic parameters: for the row data and the row input - initialization will look like this:
helper.NewApiExtractor[[]GithubAccountOrgsResponse, SimpleAccountWithId](...)Related issues
n/a
Additional context
n/a
Reacted by Likyh
Activity
github-actions commentedon Nov 29, 2022
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
github-actions commentedon Feb 20, 2023
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
Startrekzky commentedon Feb 20, 2023
Bump
coldgust commentedon Mar 6, 2023
Hello, I would like to finish this task，could you assign this to me?
7 remaining items
Dev79844 commentedon Jun 20, 2023
Hey @keon94 ! Is anyone working on this issue? If not can you assign it to me
keon94 commentedon Jun 20, 2023
@Dev79844 I don't believe so. Sure, you can have it. Thanks for taking it on.
github-actions commentedon Jul 26, 2023
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
github-actions commentedon Sep 25, 2023
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
github-actions commentedon Nov 25, 2023
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
github-actions commentedon Dec 2, 2023
This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.