[homebeaver]

Hi @garydgregory ,

here is EUgen from Europe.
With this PR I provide validation and check digit calculation for VAT Id Numbers VATIN for all countries in the EU. This number is neccessary in the intra comunity trades to apply a zero VAT rate.
You can find a documentation of the different VATINs structures in my VATIN wiki (de)

The validator for all is VATINValidator - it implements the jira issue 494

Pls review and merge.
Regards EUGen

[homebeaver]

Hi @sebbASF , @sebbASF

when merging apache/master to my repo branch I got an error in pom.xml

- cvc-elt.1.a: Cannot find the declaration of element 'project'.
- Downloading external resources is disabled.

The solution is https instead http in pom element 'project'

I resolve this in my pull request and hope you accept this pull. It is waiting to be accepted for more then one year!

regards EUGen

[sebbASF]

Please revert these changes. They are not valid.

Although the values look like URLs, they are not; they are unique identifiers so must be left as is

[raboof]

I resolve this in my pull request and hope you accept this pull. It is waiting to be accepted for more then one year!

As mentioned earlier in #271 (comment): keeping this up-to-date looks like quite a maintenance burden. This means the work is valuable to share - but only if we're confident that there will be someone looking after this code after it's merged. I assume you're using this and would be ready to take some of that maintainership on yourself, but it'd be good to have one or two other people showing up.

[homebeaver]

tkx @raboof.
Changes can be cleanly merged. @garydgregory

[garydgregory]

I resolve this in my pull request and hope you accept this pull. It is waiting to be accepted for more then one year!

As mentioned earlier in #271 (comment): keeping this up-to-date looks like quite a maintenance burden. This means the work is valuable to share - but only if we're confident that there will be someone looking after this code after it's merged. I assume you're using this and would be ready to take some of that maintainership on yourself, but it'd be good to have one or two other people showing up.

There has been no reply from @homebeaver to your comment @raboof, which doesn't inspire confidence that this will be maintained.

[garydgregory]

@homebeaver At least one of my comments hasn't been addressed; it was marked resolved, which is not appropriate IMO, so I stopped looking. Beyond that, I'm not sure there is consensus to bring this in due to the maintenance burden. What do others think?

[sebbASF]

I agree that this is likely to become too much of a maintenance burden.

Seems to me this would be better as a separate project (with its own package name).
This could of course use existing Validator methods where appropriate.

It might be worth considering adding some or all of the new ModulusCheckDigit classes, if the algorithm is standardised and in general use.

[homebeaver]

... would be better as a separate project (with its own package name).

I'll do it.